r69439 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r69438‎ | r69439 | r69440 >
Date:20:28, 16 July 2010
Author:neilk
Status:deferred
Tags:
Comment:
make function static, since it's called that way -- eliminates warnings. Probably a lot of others in this module that need to be static
Modified paths:
  • /trunk/extensions/JS2Support/mwEmbed/includes/NamedResourceLoader.php (modified) (history)

Diff [purge]

Index: trunk/extensions/JS2Support/mwEmbed/includes/NamedResourceLoader.php
@@ -302,7 +302,7 @@
303303 * Return the module name for a given resource or false if not found
304304 * @param $resourceName resource to get the module for
305305 */
306 - public function getModuleNameForResource( $resourceName ){
 306+ public static function getModuleNameForResource( $resourceName ){
307307 if( isset( self::$resourceParentModuleName [ $resourceName ] ) ){
308308 return self::$resourceParentModuleName [ $resourceName ];
309309 } else {

Status & tagging log