r69435 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r69434‎ | r69435 | r69436 >
Date:19:22, 16 July 2010
Author:raymond
Status:ok
Tags:
Comment:
Add username to messages to make them clearer and allow GENDER per request on Translatewiki
Modified paths:
  • /trunk/extensions/EditUser/EditUser.i18n.php (modified) (history)
  • /trunk/extensions/EditUser/EditUser_body.php (modified) (history)

Diff [purge]

Index: trunk/extensions/EditUser/EditUser_body.php
@@ -31,12 +31,12 @@
3232 }
3333 $targetuser = User::NewFromName( $this->target );
3434 if( $targetuser->getID() == 0 ) {
35 - $wgOut->addWikiText( wfMsg( 'edituser-nouser' ) );
 35+ $wgOut->addWikiMsg( 'edituser-nouser', htmlspecialchars( $this->target ) );
3636 return;
3737 }
3838 #Allow editing self via this interface
3939 if( $targetuser->isAllowed( 'edituser-exempt' ) && $targetuser->getName() != $wgUser->getName() ) {
40 - $wgOut->addWikiText( wfMsg( 'edituser-exempt' ) );
 40+ $wgOut->addWikiMsg( 'edituser-exempt', $targetuser->getName() );
4141 return;
4242 }
4343
Index: trunk/extensions/EditUser/EditUser.i18n.php
@@ -16,8 +16,8 @@
1717 'edituser' => 'Edit user',
1818 'edituser-username' => 'Username:',
1919 'edituser-dosearch' => 'Search',
20 - 'edituser-nouser' => 'The specified user does not exist.',
21 - 'edituser-exempt' => 'The specified user cannot be edited.',
 20+ 'edituser-nouser' => 'The user "$1" does not exist.',
 21+ 'edituser-exempt' => 'The user "$1" cannot be edited.',
2222 'right-edituser' => 'Edit the preferences of other users',
2323 'right-edituser-exempt' => "Others cannot edit this user's preferences",
2424 );

Status & tagging log