r69425 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r69424‎ | r69425 | r69426 >
Date:13:57, 16 July 2010
Author:hartman
Status:ok
Tags:
Comment:
When we have a bogus useskin value, fallback to $wgDefaultSkin if that value is sane. Fallback to hardcoded "vector" default if $wgDefaultSkin is bogus. Users who still have amathyst selected as their skin preference, should now get vector instead of monobook. Follow up to r66383.
Modified paths:
  • /trunk/phase3/includes/Skin.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/Skin.php
@@ -115,8 +115,10 @@
116116
117117 if( isset( $skinNames[$key] ) ) {
118118 return $key;
 119+ } else if( isset( $skinNames[$wgDefaultSkin] ) ) {
 120+ return $wgDefaultSkin;
119121 } else {
120 - return 'monobook';
 122+ return 'vector';
121123 }
122124 }
123125

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r66383Being bold and changing the default skin. Monobook est mort, vive le Vector!demon19:50, 13 May 2010

Status & tagging log