r69371 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r69370‎ | r69371 | r69372 >
Date:01:37, 15 July 2010
Author:yaron
Status:deferred
Tags:
Comment:
Better check for existence of field
Modified paths:
  • /trunk/extensions/ApprovedRevs/ApprovedRevs_body.php (modified) (history)

Diff [purge]

Index: trunk/extensions/ApprovedRevs/ApprovedRevs_body.php
@@ -53,7 +53,7 @@
5454 public static function pageIsApprovable( $title ) {
5555 // if this function was already called for this page, the
5656 // value should have been stored as a field in the $title object
57 - if ( ! is_null( $title->isApprovable ) ) {
 57+ if ( isset( $title->isApprovable ) ) {
5858 return $title->isApprovable;
5959 }
6060

Status & tagging log