r69368 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r69367‎ | r69368 | r69369 >
Date:00:38, 15 July 2010
Author:jeroendedauw
Status:deferred
Tags:
Comment:
Follow up to r69365
Modified paths:
  • /trunk/extensions/Deployment/includes/filesystems/Ssh2Filesystem.php (modified) (history)

Diff [purge]

Index: trunk/extensions/Deployment/includes/filesystems/Ssh2Filesystem.php
@@ -362,13 +362,13 @@
363363 return false;
364364 }
365365
366 - while (false !== ( $entry = $dir->read() ) ) {
 366+ while ( ( $entry = $dir->read() ) !== false ) {
367367 $struc = array();
368368 $struc['name'] = $entry;
369369
370370 if (
371 - ('.' == $struc['name'] || '..' == $struc['name'] )
372 - || ( !$includeHidden && '.' == $struc['name'][0] )
 371+ ( $struc['name'] == '.' || $struc['name'] == '..' )
 372+ || ( !$includeHidden && $struc['name'][0] == '.' )
373373 || ( $limit_file && $struc['name'] != $limit_file )
374374 ) {
375375 continue; // Do not care about these folders.
@@ -386,7 +386,7 @@
387387 $struc['time'] = date( 'h:i:s', $struc['lastmodunix'] );
388388 $struc['type'] = $this->isDir( $entryPath ) ? 'd' : 'f';
389389
390 - if ( 'd' == $struc['type'] ) {
 390+ if ( $struc['type'] == 'd' ) {
391391 if ( $recursive ) {
392392 $struc['files'] = $this->listDir( $path . '/' . $struc['name'], $includeHidden, $recursive );
393393 }

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r69365Work on porting WP filesystem abstraction classesjeroendedauw00:29, 15 July 2010

Status & tagging log