r69362 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r69361‎ | r69362 | r69363 >
Date:23:57, 14 July 2010
Author:aaron
Status:ok
Tags:
Comment:
Msg cleanups and another formatNum
Modified paths:
  • /trunk/extensions/FlaggedRevs/specialpages/ConfiguredPages_body.php (modified) (history)
  • /trunk/extensions/FlaggedRevs/specialpages/ValidationStatistics_body.php (modified) (history)

Diff [purge]

Index: trunk/extensions/FlaggedRevs/specialpages/ConfiguredPages_body.php
@@ -28,7 +28,7 @@
2929
3030 protected function showForm() {
3131 global $wgOut, $wgScript;
32 - $wgOut->addHTML( wfMsgExt( 'configuredpages-text', array( 'parseinline' ) ) );
 32+ $wgOut->addWikiMsg( 'configuredpages-text' );
3333 $fields = array();
3434 # Namespace selector
3535 if ( count( FlaggedRevs::getReviewNamespaces() ) > 1 ) {
@@ -66,7 +66,7 @@
6767 $wgOut->addHTML( $pager->getBody() );
6868 $wgOut->addHTML( $pager->getNavigationBar() );
6969 } else {
70 - $wgOut->addHTML( wfMsgExt( 'configuredpages-none', array( 'parse' ) ) );
 70+ $wgOut->addWikiMsg( 'configuredpages-none' );
7171 }
7272 # Take this opportunity to purge out expired configurations
7373 FlaggedRevs::purgeExpiredConfigurations();
@@ -84,7 +84,7 @@
8585 'page=' . $title->getPrefixedUrl()
8686 );
8787 # Show which version is the default (stable or draft)
88 - if( intval( $row->fpc_override ) ) {
 88+ if ( intval( $row->fpc_override ) ) {
8989 $default = wfMsgHtml( 'configuredpages-def-stable' );
9090 } else {
9191 $default = wfMsgHtml( 'configuredpages-def-draft' );
@@ -100,12 +100,12 @@
101101 } elseif( $select === FLAGGED_VIS_LATEST ) {
102102 $type = wfMsgHtml( 'configuredpages-prec-none' );
103103 }
104 - if( $type ) $type = "({$type})";
 104+ if ( $type ) $type = "({$type})";
105105 }
106106 # Autoreview/review restriction level
107107 $restr = '';
108 - if( $row->fpc_level != '' ) {
109 - $restr = 'autoreview='.htmlspecialchars($row->fpc_level);
 108+ if ( $row->fpc_level != '' ) {
 109+ $restr = 'autoreview=' . htmlspecialchars( $row->fpc_level );
110110 $restr = "[$restr]";
111111 }
112112 # When these configuration settings expire
Index: trunk/extensions/FlaggedRevs/specialpages/ValidationStatistics_body.php
@@ -148,7 +148,7 @@
149149 '</th><th>' . wfMsgHtml( 'validationstatistics-reviews' ) . '</th></tr>';
150150 foreach ( $data as $userId => $reviews ) {
151151 $reviewChart .= '<tr><td>' . htmlspecialchars( User::whois( $userId ) ) .
152 - '</td><td>' . intval( $reviews ) . '</td></tr>';
 152+ '</td><td>' . $wgLang->formatNum( $reviews ) . '</td></tr>';
153153 }
154154 $reviewChart .= "</table>\n";
155155 $wgOut->addHTML( $reviewChart );

Status & tagging log