r69323 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r69322‎ | r69323 | r69324 >
Date:01:27, 14 July 2010
Author:yaron
Status:ok
Tags:
Comment:
Better formatting for code, removed unneeded variables; r69311
Modified paths:
  • /trunk/extensions/ApprovedRevs/ApprovedRevs.hooks.php (modified) (history)

Diff [purge]

Index: trunk/extensions/ApprovedRevs/ApprovedRevs.hooks.php
@@ -20,7 +20,7 @@
2121 if ( $action == 'submit' ) {
2222 $title = $parser->getTitle();
2323 $approvedText = ApprovedRevs::getApprovedContent( $title );
24 - if ( ! is_null( $approvedText ) ) {
 24+ if ( !is_null( $approvedText ) ) {
2525 $text = $approvedText;
2626 }
2727 }
@@ -259,7 +259,7 @@
260260 */
261261 static function setTranscludedPageRev( $parser, &$title, &$skip, &$id ) {
262262 $revision_id = ApprovedRevs::getApprovedRevID( $title );
263 - if ( ! is_null( $revision_id ) ) {
 263+ if ( !is_null( $revision_id ) ) {
264264 $id = $revision_id;
265265 }
266266 return true;
@@ -298,7 +298,6 @@
299299 * 'APPROVEDREVS' magic word in a page
300300 */
301301 static function handleMagicWords( &$parser, &$text ) {
302 - global $wgOut, $wgAction;
303302 $mw_hide = MagicWord::get( 'MAG_APPROVEDREVS' );
304303 if ( $mw_hide->matchAndRemove( $text ) ) {
305304 $parser->mOutput->setProperty( 'approvedrevs', 'y' );

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r69311__APPROVEDREVS__ magic word added - sets "approvability"; hasSupportedNamespa...yaron19:53, 13 July 2010

Status & tagging log