r69232 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r69231‎ | r69232 | r69233 >
Date:10:39, 10 July 2010
Author:demon
Status:ok
Tags:
Comment:
Partial revert r69231, unrelated and unfinished installer changes
Modified paths:
  • /trunk/phase3/includes/installer/Installer.php (modified) (history)
  • /trunk/phase3/includes/installer/WebInstaller.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/installer/WebInstaller.php
@@ -981,20 +981,12 @@
982982 }
983983 $this->parent->output->addWikiText( wfMsgNoTrans( 'config-welcome' ) );
984984 $status = $this->parent->doEnvironmentChecks();
985 - if ( $status->isOk() ) {
 985+ if ( $status ) {
986986 $this->parent->output->addWikiText( wfMsgNoTrans( 'config-copyright', wfMsg( 'config-authors' ) ) );
987987 $this->startForm();
988988 $this->endForm();
989989 }
990990 }
991 -
992 - public function beginEnvCheck( $step ) {
993 -
994 - }
995 -
996 - public function endEnvCheck( $step, $status ) {
997 -
998 - }
999991 }
1000992
1001993 class WebInstaller_DBConnect extends WebInstallerPage {
Index: trunk/phase3/includes/installer/Installer.php
@@ -298,17 +298,15 @@
299299 * Under the web subclass, it can already be assumed that PHP 5+ is in use
300300 * and that sessions are working.
301301 */
302 - function doEnvironmentChecks( $beginCB, $endCB ) {
 302+ function doEnvironmentChecks() {
303303 $this->showMessage( 'config-env-php', phpversion() );
304304
305305 $good = true;
306306 foreach ( $this->envChecks as $check ) {
307 - call_user_func_array( $beginCB, array( $check ) );
308307 $status = $this->$check();
309308 if ( $status === false ) {
310309 $good = false;
311310 }
312 - call_user_func_array( $endCB, array( $check, $status ) );
313311 }
314312 $this->setVar( '_Environment', $good );
315313 if ( $good ) {

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r69231(bug 24303) Expose hostname in API results. Show via servedby parameter, adde...demon10:37, 10 July 2010

Status & tagging log