r69219 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r69218‎ | r69219 | r69220 >
Date:20:53, 9 July 2010
Author:demon
Status:ok
Tags:
Comment:
Reduce some duplication
Modified paths:
  • /trunk/phase3/includes/installer/WebInstaller.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/installer/WebInstaller.php
@@ -1584,8 +1584,6 @@
15851585 $status = new Status();
15861586 $status->warning( 'config-install-alreadydone' );
15871587 $this->parent->showStatusBox( $status );
1588 - $this->endForm();
1589 - return true;
15901588 } else {
15911589 $this->startForm();
15921590 $this->addHTML("<ul>");
@@ -1594,10 +1592,9 @@
15951593 array( $this, 'endStage' )
15961594 );
15971595 $this->addHTML("</ul>");
1598 - $this->endForm();
1599 - return true;
16001596 }
1601 -
 1597+ $this->endForm();
 1598+ return true;
16021599 }
16031600
16041601 public function startStage( $step ) {

Status & tagging log