r69184 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r69183‎ | r69184 | r69185 >
Date:12:57, 8 July 2010
Author:jeroendedauw
Status:deferred
Tags:
Comment:
Follow up to r69156
Modified paths:
  • /trunk/extensions/Deployment/includes/filesystems/FtpFilesystem.php (modified) (history)
  • /trunk/extensions/Deployment/includes/filesystems/Ssh2Filesystem.php (modified) (history)

Diff [purge]

Index: trunk/extensions/Deployment/includes/filesystems/FtpFilesystem.php
@@ -95,7 +95,7 @@
9696
9797 // Check if a connection has been established.
9898 if ( !$this->connection ) {
99 - $this->addErrorMessage( wfMsgExt( 'deploy-ftp-connect-failed', $this->options['hostname'], $this->options['port'] ) );
 99+ $this->addErrorMessage( wfMsgExt( 'deploy-ftp-connect-failed', 'parsemag', $this->options['hostname'], $this->options['port'] ) );
100100 return false;
101101 }
102102
Index: trunk/extensions/Deployment/includes/filesystems/Ssh2Filesystem.php
@@ -118,7 +118,7 @@
119119 }
120120
121121 if ( !$this->connection ) {
122 - $this->addErrorMessage( wfMsgExt( 'deploy-ssh2-connect-failed', $this->options['hostname'], $this->options['port'] ) );
 122+ $this->addErrorMessage( wfMsgExt( 'deploy-ssh2-connect-failed', 'parsemag', $this->options['hostname'], $this->options['port'] ) );
123123 return false;
124124 }
125125
@@ -126,7 +126,7 @@
127127 $ssh2_auth_pubkey_file = ssh2_auth_pubkey_file( $this->link, $this->options['username'], $this->options['public_key'], $this->options['private_key'], $this->options['password'] );
128128
129129 if ( !$ssh2_auth_pubkey_file ) {
130 - $this->addErrorMessage( wfMsgExt( 'deploy-ssh2-key-authentication-failed', $this->options['username'] ) );
 130+ $this->addErrorMessage( wfMsgExt( 'deploy-ssh2-key-authentication-failed', 'parsemag', $this->options['username'] ) );
131131 return false;
132132 }
133133
@@ -134,7 +134,7 @@
135135 $ssh2_auth_password = ssh2_auth_password( $this->connection, $this->options['username'], $this->options['password'] );
136136
137137 if ( !$ssh2_auth_password ) {
138 - $this->addErrorMessage( wfMsgExt( 'deploy-ssh2-password-authentication-failed', $this->options['username'] ) );
 138+ $this->addErrorMessage( wfMsgExt( 'deploy-ssh2-password-authentication-failed', 'parsemag', $this->options['username'] ) );
139139 return false;
140140 }
141141 }
@@ -333,7 +333,7 @@
334334 return $data;
335335 }
336336 else {
337 - $this->addErrorMessage( wfMsgExt( 'deploy-ssh2-command-failed', $command ) );
 337+ $this->addErrorMessage( wfMsgExt( 'deploy-ssh2-command-failed', 'parsemag', $command ) );
338338 return false;
339339 }
340340 }

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r69156Work on porting WP filesystem abstraction classesjeroendedauw21:31, 7 July 2010

Status & tagging log