r69147 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r69146‎ | r69147 | r69148 >
Date:15:05, 7 July 2010
Author:avar
Status:ok
Tags:
Comment:
new-installer: Revert DB driver check breakage in r69128

We should use isCompiled() to check if we can actually use a DB
driver. Just constructing the object isn't enough. r69128 regressed so
that the installed displayed Oracle as an option for me, even though I
have no driver for it.
Modified paths:
  • /trunk/phase3/includes/installer/Installer.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/installer/Installer.php
——@@ -404,7 +404,7 @@
405405 foreach ( $this->dbTypes as $name ) {
406406 $db = $this->getDBInstaller( $name );
407407 $readableName = wfMsg( 'config-type-' . $name );
408 - if ( $db ) {
 408+ if ( $db->isCompiled() ) {
409409 $compiledDBs[] = $name;
410410 $goodNames[] = $readableName;
411411 }

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r69128* Add Status::getWarningsArray() to complement Status::getErrorsArray()...mah02:53, 7 July 2010

Status & tagging log