r69138 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r69137‎ | r69138 | r69139 >
Date:10:55, 7 July 2010
Author:avar
Status:ok
Tags:
Comment:
new-installer: WebInstaller's ->finish method needs to be public, not private

It's called from new-index.php if we can't start a session:

$installer = new WebInstaller( $wgRequest );

if ( !$installer->startSession() ) {
$installer->finish();

Resulting in:

[07-Jul-2010 10:37:00] PHP Fatal error: Call to private method WebInstaller::finish() from context '' in /home/avar/g/phase3/config/new-index.php on line 12
Modified paths:
  • /trunk/phase3/includes/installer/WebInstaller.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/installer/WebInstaller.php
——@@ -278,7 +278,7 @@
279279 /**
280280 * Clean up from execute()
281281 */
282 - private function finish() {
 282+ public function finish() {
283283 $this->output->output();
284284 $this->session['happyPages'] = $this->happyPages;
285285 $this->session['skippedPages'] = $this->skippedPages;

Status & tagging log