r69122 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r69121‎ | r69122 | r69123 >
Date:00:18, 7 July 2010
Author:jeroendedauw
Status:deferred
Tags:
Comment:
Added docs
Modified paths:
  • /trunk/extensions/Maps/Services/Maps_MappingService.php (modified) (history)
  • /trunk/extensions/Maps/Services/OSM/Maps_OSM.php (modified) (history)
  • /trunk/extensions/Maps/Services/OSM/Maps_OSMDispMap.php (modified) (history)
  • /trunk/extensions/Maps/Services/OSM/OSM.php (modified) (history)

Diff [purge]

Index: trunk/extensions/Maps/Services/Maps_MappingService.php
@@ -1,7 +1,7 @@
22 <?php
33
44 /**
5 - * This file holds the general information for the Google Maps service
 5+ * File holding the MapsMappingService class.
66 *
77 * @file Maps_MappingService.php
88 * @ingroup Maps
@@ -13,38 +13,57 @@
1414 die( 'Not an entry point.' );
1515 }
1616
 17+/**
 18+ * Base class for mapping services. Deriving classes hold mapping service specific
 19+ * information and functionality, which can be used by any mapping feature.
 20+ *
 21+ * @since 0.6.3
 22+ *
 23+ * @author Jeroen De Dauw
 24+ */
1725 class MapsMappingService implements iMappingService {
1826
1927 /**
 28+ * The internal name of the service.
2029 *
2130 * @var string
2231 */
2332 protected $mServiceName;
2433
2534 /**
 35+ * A list of aliases for the internal name.
2636 *
2737 * @var array
2838 */
2939 protected $mAliases;
3040
3141 /**
 42+ * A list of features that support the service, used for validation and defaulting.
3243 *
3344 * @var array
3445 */
3546 protected $mFeatures;
3647
3748 /**
 49+ * A list of parameter info specific to the service, which can be used by any feature
 50+ * to pass along to Validator to handle parameters.
3851 *
3952 * @var mixed Array or false
4053 */
4154 private $mParameterInfo = false;
4255
4356 /**
 57+ * A list of dependencies (header items) that have been added.
4458 *
4559 * @var array
4660 */
4761 private $mAddedDependencies = array();
4862
 63+ /**
 64+ * A list of dependencies (header items) that need to be added.
 65+ *
 66+ * @var array
 67+ */
4968 private $mDependencies = array();
5069
5170 /**
Index: trunk/extensions/Maps/Services/OSM/Maps_OSMDispMap.php
@@ -1,7 +1,7 @@
22 <?php
33
44 /**
5 - * Class for handling the display_map parser function with OSM
 5+ * File holding the MapsOSMDispMap class.
66 *
77 * @file Maps_OSMDispMap.php
88 * @ingroup OSM
@@ -13,8 +13,20 @@
1414 die( 'Not an entry point.' );
1515 }
1616
 17+/**
 18+ * Class for handling the display_map parser function with OSM.
 19+ *
 20+ * @since 0.6.4
 21+ *
 22+ * @ingroup OSM
 23+ *
 24+ * @author Jeroen De Dauw
 25+ */
1726 class MapsOSMDispMap extends MapsBaseMap {
1827
 28+ /**
 29+ * @since 0.6.4
 30+ */
1931 protected function getDefaultZoom() {
2032 global $egMapsOSMZoom;
2133 return $egMapsOSMZoom;
@@ -22,6 +34,8 @@
2335
2436 /**
2537 * @see MapsBaseMap::addSpecificMapHTML()
 38+ *
 39+ * @since 0.6.4
2640 */
2741 public function addSpecificMapHTML() {
2842 global $egMapsOSMPrefix, $egOSMOnThisPage;
Index: trunk/extensions/Maps/Services/OSM/Maps_OSM.php
@@ -14,14 +14,22 @@
1515 }
1616
1717 /**
18 - * TODO
 18+ * Class holding information and functionallity specific to OSM.
 19+ * This infomation and features can be used by any mapping feature.
1920 *
 21+ * @since 0.6.4
 22+ *
2023 * @ingroup OSM
2124 *
2225 * @author Jeroen De Dauw
2326 */
2427 class MapsOSM extends MapsMappingService {
2528
 29+ /**
 30+ * Constructor.
 31+ *
 32+ * @since 0.6.4
 33+ */
2634 function __construct() {
2735 parent::__construct(
2836 'osm',
Index: trunk/extensions/Maps/Services/OSM/OSM.php
@@ -22,6 +22,13 @@
2323
2424 $wgHooks['MappingServiceLoad'][] = 'efMapsInitOSM';
2525
 26+/**
 27+ * Initialization function for the OSM service.
 28+ *
 29+ * @since 0.6.4
 30+ *
 31+ * @return true
 32+ */
2633 function efMapsInitOSM() {
2734 global $egMapsServices, $wgAutoloadClasses;
2835

Status & tagging log