r69119 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r69118‎ | r69119 | r69120 >
Date:23:53, 6 July 2010
Author:jeroendedauw
Status:deferred
Tags:
Comment:
Added docs
Modified paths:
  • /trunk/extensions/Maps/Geocoders/Maps_BaseGeocoder.php (modified) (history)
  • /trunk/extensions/Maps/Includes/Maps_Mapper.php (modified) (history)
  • /trunk/extensions/Maps/Maps.php (modified) (history)

Diff [purge]

Index: trunk/extensions/Maps/Includes/Maps_Mapper.php
@@ -12,6 +12,13 @@
1313 die( 'Not an entry point.' );
1414 }
1515
 16+/**
 17+ * Class with generic mapping methods.
 18+ *
 19+ * @since 0.1
 20+ *
 21+ * @author Jeroen De Dauw
 22+ */
1623 final class MapsMapper {
1724
1825 /**
@@ -306,4 +313,4 @@
307314 ),
308315 );
309316 }
310 -}
 317+}
\ No newline at end of file
Index: trunk/extensions/Maps/Maps.php
@@ -79,6 +79,8 @@
8080 /**
8181 * Initialization function for the Maps extension.
8282 *
 83+ * @since 0.1
 84+ *
8385 * @return true
8486 */
8587 function efMapsSetup() {
@@ -142,6 +144,8 @@
143145 /**
144146 * Adds a link to Admin Links page.
145147 *
 148+ * @since 0.2
 149+ *
146150 * @return true
147151 */
148152 function efMapsAddToAdminLinks( &$admin_links_tree ) {
Index: trunk/extensions/Maps/Geocoders/Maps_BaseGeocoder.php
@@ -1,7 +1,7 @@
22 <?php
33
44 /**
5 - * MapsBaseGeocoder is an abstract class inherited by the geocoding classes
 5+ * File holding the MapsBaseGeocoder class.
66 *
77 * @file Maps_BaseGeocoder.php
88 * @ingroup Maps
@@ -13,6 +13,14 @@
1414 die( 'Not an entry point.' );
1515 }
1616
 17+/**
 18+ * MapsBaseGeocoder is an abstract class inherited by the geocoding classes.
 19+ *
 20+ * @ingroup Maps
 21+ * @since 0.2
 22+ *
 23+ * @author Jeroen De Dauw
 24+ */
1725 abstract class MapsBaseGeocoder {
1826
1927 /**
@@ -20,7 +28,11 @@
2129 * longitude (lon) of the provided address, or false in case the
2230 * geocoding fails.
2331 *
24 - * @param string $address
 32+ * @since 0.2
 33+ *
 34+ * @param $address String: the address to be geocoded
 35+ *
 36+ * @return string or false
2537 */
2638 public static function geocode( $address ) {
2739 return false; // This method needs to be overriden, if it's not, return false.
@@ -29,7 +41,10 @@
3042 /**
3143 * Returns the content of the requested file, or false when the connection fails
3244 *
33 - * @param string $requestURL
 45+ * @since 0.2
 46+ *
 47+ * @param $requestURL String: the url to make the request to
 48+ *
3449 * @return string or false
3550 */
3651 protected static function GetResponse( $requestURL ) {
@@ -46,7 +61,8 @@
4762 * Attempts to get the contents of a file via cURL request and
4863 * returns it, or false when the attempt fails.
4964 *
50 - * @param string $requestURL
 65+ * @param $requestURL String: the url to make the request to
 66+ *
5167 * @return string or false
5268 */
5369 protected static function GetCurlResponse( $requestURL ) {

Status & tagging log