r69114 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r69113‎ | r69114 | r69115 >
Date:21:31, 6 July 2010
Author:neilk
Status:deferred
Tags:
Comment:
description adder fixed, fixed layout for description deleter boxes, removed some html divs from the object properties
Modified paths:
  • /trunk/extensions/UploadWizard/js/mw.UploadWizard.js (modified) (history)
  • /trunk/extensions/UploadWizard/styles/uploadWizard.css (modified) (history)

Diff [purge]

Index: trunk/extensions/UploadWizard/styles/uploadWizard.css
@@ -272,9 +272,10 @@
273273 vertical-align: middle;
274274 }
275275
 276+/* I don't like that this has to have width, to ensure that all the floats work out correctly.*/
276277 .mwe-upwiz-data {
277278 float: left;
278 - width: 44em;
 279+ width: 46em;
279280 }
280281
281282
Index: trunk/extensions/UploadWizard/js/mw.UploadWizard.js
@@ -1127,7 +1127,7 @@
11281128
11291129 _this.titleErrorDiv = $j('<div class="mwe-upwiz-details-input-error"><label class="mwe-error" for="' + _this.titleId + '" generated="true"/></div>');
11301130
1131 - _this.titleContainerDiv = $j('<div class="mwe-upwiz-details-fieldname-input ui-helper-clearfix"></div>')
 1131+ var titleContainerDiv = $j('<div class="mwe-upwiz-details-fieldname-input ui-helper-clearfix"></div>')
11321132 .append(
11331133 _this.titleErrorDiv,
11341134 $j( '<div class="mwe-upwiz-details-fieldname"></div>' )
@@ -1145,9 +1145,9 @@
11461146 _this.deedDiv
11471147 );
11481148
1149 - _this.moreDetailsDiv = $j('<div class="mwe-more-details"></div>');
 1149+ moreDetailsDiv = $j('<div class="mwe-more-details"></div>');
11501150
1151 - _this.moreDetailsCtrlDiv = $j( '<div class="mwe-upwiz-details-more-options"></div>' );
 1151+ moreDetailsCtrlDiv = $j( '<div class="mwe-upwiz-details-more-options"></div>' );
11521152
11531153 var dateInputId = "dateInput" + ( _this.upload.index ).toString();
11541154 var dateDisplayInputId = "dateDisplayInput" + ( _this.upload.index ).toString();
@@ -1180,7 +1180,7 @@
11811181 .append( _this.otherInformationInput );
11821182
11831183
1184 - $j( _this.moreDetailsDiv ).append(
 1184+ $j( moreDetailsDiv ).append(
11851185 dateInputDiv,
11861186 // location goes here
11871187 otherInformationDiv
@@ -1189,10 +1189,11 @@
11901190 _this.$form = $j( '<form></form>' );
11911191 _this.$form.append(
11921192 _this.descriptionsDiv,
1193 - _this.titleContainerDiv,
 1193+ descriptionAdderDiv,
 1194+ titleContainerDiv,
11941195 _this.copyrightInfoFieldset,
1195 - _this.moreDetailsCtrlDiv,
1196 - _this.moreDetailsDiv
 1196+ moreDetailsCtrlDiv,
 1197+ moreDetailsDiv
11971198 );
11981199
11991200 $j( _this.dataDiv ).append(
@@ -1235,7 +1236,7 @@
12361237 /* if the date is not valid, we need to pop open the "more options". How?
12371238 guess we'll revalidate it with element */
12381239
1239 - mw.UploadWizardUtil.makeToggler( _this.moreDetailsCtrlDiv, _this.moreDetailsDiv );
 1240+ mw.UploadWizardUtil.makeToggler( moreDetailsCtrlDiv, moreDetailsDiv );
12401241
12411242 _this.addDescription( true, mw.getConfig('userLanguage') );
12421243 $j( containerDiv ).append( _this.div );
@@ -1262,7 +1263,8 @@
12631264 alert( "please wait, still checking the title for uniqueness..." );
12641265 return false;
12651266 }
1266 -
 1267+
 1268+ // all other fields validated with validator js
12671269 var formValid = _this.$form.valid();
12681270 return titleInputValid && formValid;
12691271
@@ -2033,8 +2035,6 @@
20342036 + '<div id="mwe-upwiz-add-file-container" class="mwe-upwiz-add-files-0">'
20352037 + '<a id="mwe-upwiz-add-file">' + gM("mwe-upwiz-add-file-0") + '</a>'
20362038 + '</div>'
2037 - + '<div id="proceed" class="mwe-upwiz-file-indicator">'
2038 - + '</div>'
20392039 + '</div>'
20402040 + '<div id="mwe-upwiz-progress" class="ui-helper-clearfix"></div>'
20412041 + '</div>'
@@ -2462,7 +2462,6 @@
24632463
24642464 if ( _this.uploads.length ) {
24652465 $j( '#mwe-upwiz-upload-ctrl' ).removeAttr( 'disabled' );
2466 - $j( '#proceed' ).show();
24672466 $j( '#mwe-upwiz-stepdiv-file .mwe-upwiz-buttons' ).show();
24682467 $j( '#mwe-upwiz-add-file' ).html( gM( 'mwe-upwiz-add-file-n' ) );
24692468 $j( '#mwe-upwiz-add-file-container' ).removeClass('mwe-upwiz-add-files-0');
@@ -2471,7 +2470,6 @@
24722471 $j( '#mwe-upwiz-files .mwe-upwiz-file:filled:even' ).removeClass( 'odd' );
24732472 } else {
24742473 $j( '#mwe-upwiz-upload-ctrl' ).attr( 'disabled', 'disabled' );
2475 - $j( '#proceed' ).hide();
24762474 $j( '#mwe-upwiz-stepdiv-file .mwe-upwiz-buttons' ).hide();
24772475 $j( '#mwe-upwiz-add-file' ).html( gM( 'mwe-upwiz-add-file-0' ) );
24782476 $j( '#mwe-upwiz-add-file-container' ).addClass('mwe-upwiz-add-files-0');

Status & tagging log