r69057 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r69056‎ | r69057 | r69058 >
Date:16:23, 5 July 2010
Author:jeroendedauw
Status:deferred
Tags:
Comment:
Changes for 0.6.4 - re-added service links support
Modified paths:
  • /trunk/extensions/SemanticMaps/GeoCoords/SM_GeoCoordsValue.php (modified) (history)
  • /trunk/extensions/SemanticMaps/SemanticMaps.php (modified) (history)

Diff [purge]

Index: trunk/extensions/SemanticMaps/GeoCoords/SM_GeoCoordsValue.php
@@ -282,10 +282,20 @@
283283 * Create links to mapping services based on a wiki-editable message. The parameters
284284 * available to the message are:
285285 *
 286+ * $1: The location in non-directional float notation.
 287+ * $2: The location in directional DMS notation.
 288+ * $3: The latitude in non-directional float notation.
 289+ * $4 The longitude in non-directional float notation.
 290+ *
286291 * @return array
287292 */
288293 protected function getServiceLinkParams() {
289 - return array( ); // TODO
 294+ return array(
 295+ MapsCoordinateParser::formatCoordinates( $this->mCoordinateSet, 'float', false ),
 296+ MapsCoordinateParser::formatCoordinates( $this->mCoordinateSet, 'dms', true ),
 297+ $this->mCoordinateSet['lat'],
 298+ $this->mCoordinateSet['lon']
 299+ );
290300 }
291301
292302 /**
Index: trunk/extensions/SemanticMaps/SemanticMaps.php
@@ -35,7 +35,7 @@
3636
3737 // Only initialize the extension when all dependencies are present.
3838 if ( defined( 'Maps_VERSION' ) && defined( 'SMW_VERSION' ) ) {
39 - define( 'SM_VERSION', '0.6.4 a8' );
 39+ define( 'SM_VERSION', '0.6.4 a9' );
4040
4141 $useExtensionPath = version_compare( $wgVersion, '1.16', '>=' ) && isset( $wgExtensionAssetsPath ) && $wgExtensionAssetsPath;
4242 $smgScriptPath = ( $useExtensionPath ? $wgExtensionAssetsPath : $wgScriptPath . '/extensions' ) . '/SemanticMaps';

Status & tagging log