r69025 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r69024‎ | r69025 | r69026 >
Date:22:11, 4 July 2010
Author:avar
Status:ok
Tags:
Comment:
LocalSettingsGenerator: Align the few assignments in the generated LocalSettings.php that weren't aligned

This makes the generated code prettier and easier to read.
Modified paths:
  • /trunk/phase3/includes/installer/LocalSettingsGenerator.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/installer/LocalSettingsGenerator.php
@@ -191,10 +191,10 @@
192192 \$wgEnableUserEmail = {$this->values['wgEnableUserEmail']}; # UPO
193193
194194 \$wgEmergencyContact = \"{$this->values['wgEmergencyContact']}\";
195 -\$wgPasswordSender = \"{$this->values['wgPasswordSender']}\";
 195+\$wgPasswordSender = \"{$this->values['wgPasswordSender']}\";
196196
197 -\$wgEnotifUserTalk = {$this->values['wgEnotifUserTalk']}; # UPO
198 -\$wgEnotifWatchlist = {$this->values['wgEnotifWatchlist']}; # UPO
 197+\$wgEnotifUserTalk = {$this->values['wgEnotifUserTalk']}; # UPO
 198+\$wgEnotifWatchlist = {$this->values['wgEnotifWatchlist']}; # UPO
199199 \$wgEmailAuthentication = {$this->values['wgEmailAuthentication']};
200200
201201 ## Database settings
@@ -207,12 +207,12 @@
208208 {$this->dbSettings}
209209
210210 ## Shared memory settings
211 -\$wgMainCacheType = $cacheType;
 211+\$wgMainCacheType = $cacheType;
212212 \$wgMemCachedServers = $mcservers;
213213
214214 ## To enable image uploads, make sure the 'images' directory
215215 ## is writable, then set this to true:
216 -\$wgEnableUploads = {$this->values['wgEnableUploads']};
 216+\$wgEnableUploads = {$this->values['wgEnableUploads']};
217217 {$magic}\$wgUseImageMagick = true;
218218 {$magic}\$wgImageMagickConvertCommand = \"{$this->values['wgImageMagickConvertCommand']}\";
219219
@@ -251,7 +251,7 @@
252252 ## License and Creative Commons licenses are supported so far.
253253 {$rights}\$wgEnableCreativeCommonsRdf = true;
254254 \$wgRightsPage = \"\"; # Set to the title of a wiki page that describes your license/copyright
255 -\$wgRightsUrl = \"{$this->values['wgRightsUrl']}\";
 255+\$wgRightsUrl = \"{$this->values['wgRightsUrl']}\";
256256 \$wgRightsText = \"{$this->values['wgRightsText']}\";
257257 \$wgRightsIcon = \"{$this->values['wgRightsIcon']}\";
258258 # \$wgRightsCode = \"{$this->values['wgRightsCode']}\"; # Not yet used

Status & tagging log