r69005 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r69004‎ | r69005 | r69006 >
Date:15:29, 4 July 2010
Author:demon
Status:reverted (Comments)
Tags:
Comment:
Add valid_tag to list of tables for parsertests. Mine seemed to need it
Modified paths:
  • /trunk/phase3/maintenance/parserTests.inc (modified) (history)

Diff [purge]

Index: trunk/phase3/maintenance/parserTests.inc
——@@ -603,7 +603,7 @@
604604 'site_stats', 'hitcounter', 'ipblocks', 'image', 'oldimage',
605605 'recentchanges', 'watchlist', 'math', 'interwiki',
606606 'querycache', 'objectcache', 'job', 'l10n_cache', 'redirect', 'querycachetwo',
607 - 'archive', 'user_groups', 'page_props', 'category'
 607+ 'archive', 'user_groups', 'page_props', 'category', 'valid_tag',
608608 );
609609
610610 if ( $wgDBtype === 'mysql' )

Follow-up revisions

RevisionCommit summaryAuthorDate
r69111Revert r69005 (adding valid_tag to parsertest tables). Not sure what freaky m...demon20:44, 6 July 2010
r69392Followup to r69005, turns out it was FlaggedRevs causing the problem. It need...demon16:47, 15 July 2010

Comments

#Comment by MaxSem (talk | contribs)   15:43, 4 July 2010

Worked for me without that change. If an extension needs an extra table duplicated, it should use the ParserTestTables hook.

Status & tagging log