r69004 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r69003‎ | r69004 | r69005 >
Date:15:06, 4 July 2010
Author:jeroendedauw
Status:deferred
Tags:
Comment:
Follow up to r69002
Modified paths:
  • /trunk/extensions/Deployment/includes/filesystems/FtpFilesystem.php (modified) (history)

Diff [purge]

Index: trunk/extensions/Deployment/includes/filesystems/FtpFilesystem.php
@@ -541,7 +541,9 @@
542542 $b['year'] = $lucifer[3];
543543 $b['hour'] = $lucifer[4];
544544 $b['minute'] = $lucifer[5];
545 - $b['time'] = @mktime($lucifer[4] + (strcasecmp($lucifer[6], "PM") == 0 ? 12 : 0), $lucifer[5], 0, $lucifer[1], $lucifer[2], $lucifer[3]);
 545+ wfSuppressWarnings();
 546+ $b['time'] = mktime( $lucifer[4] + (strcasecmp($lucifer[6], 'PM' ) == 0 ? 12 : 0), $lucifer[5], 0, $lucifer[1], $lucifer[2], $lucifer[3] );
 547+ wfRestoreWarnings();
546548 $b['am/pm'] = $lucifer[6];
547549 $b['name'] = $lucifer[8];
548550 } elseif ( !$is_windows && $lucifer = preg_split( '/[ ]/', $line, 9, PREG_SPLIT_NO_EMPTY ) ) {

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r69002Work on porting WP filesystem abstraction classesjeroendedauw15:00, 4 July 2010

Status & tagging log