r68968 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r68967‎ | r68968 | r68969 >
Date:19:51, 3 July 2010
Author:raymond
Status:ok
Tags:
Comment:
Follow-up r68904: Rename 'ImagePage.css' to 'Filepage.css': More generic name and CamelCase in messages keys is uncommon
Add 'Filepage.css' to MessagesEn.php to be sure that the message is shown on Special:AllMessages
Modified paths:
  • /trunk/phase3/RELEASE-NOTES (modified) (history)
  • /trunk/phase3/includes/filerepo/FileRepo.php (modified) (history)
  • /trunk/phase3/languages/messages/MessagesEn.php (modified) (history)
  • /trunk/phase3/maintenance/language/messageTypes.inc (modified) (history)
  • /trunk/phase3/maintenance/language/messages.inc (modified) (history)

Diff [purge]

Index: trunk/phase3/maintenance/language/messages.inc
@@ -1391,6 +1391,7 @@
13921392 'shared-repo-from',
13931393 'shared-repo',
13941394 'shared-repo-name-wikimediacommons',
 1395+ 'filepage.css',
13951396 ),
13961397 'filerevert' => array(
13971398 'filerevert',
Index: trunk/phase3/maintenance/language/messageTypes.inc
@@ -362,6 +362,7 @@
363363 'shared-repo-name-wikimediacommons',
364364 'usermessage-template',
365365 'revisionmove-backlink',
 366+ 'filepage.css',
366367 );
367368
368369 /** EXIF messages, which may be set as optional in several checks, but are generally mandatory */
Index: trunk/phase3/includes/filerepo/FileRepo.php
@@ -379,7 +379,7 @@
380380 */
381381 function getDescriptionStylesheetUrl() {
382382 if ( $this->scriptDirUrl ) {
383 - return self::makeUrl( 'title=MediaWiki:ImagePage.css&' .
 383+ return self::makeUrl( 'title=MediaWiki:Filepage.css&' .
384384 wfArrayToCGI( Skin::getDynamicStylesheetQuery() ) );
385385 }
386386 }
Index: trunk/phase3/languages/messages/MessagesEn.php
@@ -2294,6 +2294,7 @@
22952295 'shared-repo-from' => 'from $1',
22962296 'shared-repo' => 'a shared repository',
22972297 'shared-repo-name-wikimediacommons' => 'Wikimedia Commons', # only translate this message to other languages if you have to change it
 2298+'filepage.css' => '/* CSS placed here is included on the file description page, also included on foreign client wikis */', # only translate this message to other languages if you have to change it
22982299
22992300 # File reversion
23002301 'filerevert' => 'Revert $1',
Index: trunk/phase3/RELEASE-NOTES
@@ -100,7 +100,7 @@
101101 * texvc now supports \bcancel and \xcancel in addition to \cancel and \cancelto
102102 * Added scriptExtension setting to $wgForeignFileRepos
103103 * ForeignApiRepo uses scriptDirUrl if apiBase not set
104 -* (bug 24212) Added MediaWiki:ImagePage.css which is also included on foreign
 104+* (bug 24212) Added MediaWiki:Filepage.css which is also included on foreign
105105 client wikis.
106106
107107 === Bug fixes in 1.17 ===

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r68904(bug 24212) Added MediaWiki:ImagePage.css which is also included on foreign c...btongminh19:54, 2 July 2010

Status & tagging log