r68953 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r68952‎ | r68953 | r68954 >
Date:16:52, 3 July 2010
Author:jeroendedauw
Status:deferred
Tags:
Comment:
Style fix
Modified paths:
  • /trunk/extensions/Deployment/includes/filesystems/DirectFilesystem.php (modified) (history)
  • /trunk/extensions/Deployment/includes/filesystems/FtpFilesystem.php (modified) (history)

Diff [purge]

Index: trunk/extensions/Deployment/includes/filesystems/FtpFilesystem.php
@@ -109,63 +109,63 @@
110110 /**
111111 * @see Filesystem::changeDir
112112 */
113 - public function changeDir($dir) {
114 -
 113+ public function changeDir( $dir ) {
 114+ return @ftp_chdir( $this->connection, $dir );
115115 }
116116
117117 /**
118118 * @see Filesystem::changeFileGroup
119119 */
120 - public function changeFileGroup($file, $group, $recursive = false) {
 120+ public function changeFileGroup( $file, $group, $recursive = false ) {
121121
122122 }
123123
124124 /**
125125 * @see Filesystem::chmod
126126 */
127 - public function chmod($file, $mode = false, $recursive = false) {
 127+ public function chmod( $file, $mode = false, $recursive = false ) {
128128
129129 }
130130
131131 /**
132132 * @see Filesystem::chown
133133 */
134 - public function chown($file, $owner, $recursive = false) {
 134+ public function chown( $file, $owner, $recursive = false ) {
135135
136136 }
137137
138138 /**
139139 * @see Filesystem::delete
140140 */
141 - public function delete($path, $recursive = false) {
 141+ public function delete( $path, $recursive = false ) {
142142
143143 }
144144
145145 /**
146146 * @see Filesystem::doCopy
147147 */
148 - protected function doCopy($from, $to) {
 148+ protected function doCopy( $from, $to ) {
149149
150150 }
151151
152152 /**
153153 * @see Filesystem::doMove
154154 */
155 - protected function doMove($from, $to) {
 155+ protected function doMove( $from, $to ) {
156156
157157 }
158158
159159 /**
160160 * @see Filesystem::exists
161161 */
162 - public function exists($file) {
 162+ public function exists( $file ) {
163163
164164 }
165165
166166 /**
167167 * @see Filesystem::getChmod
168168 */
169 - public function getChmod($file) {
 169+ public function getChmod( $file ) {
170170
171171 }
172172
@@ -179,7 +179,7 @@
180180 /**
181181 * @see Filesystem::getCreationTime
182182 */
183 - public function getCreationTime($file) {
 183+ public function getCreationTime( $file ) {
184184
185185 }
186186
@@ -193,85 +193,85 @@
194194 /**
195195 * @see Filesystem::getGroup
196196 */
197 - public function getGroup($file) {
 197+ public function getGroup( $file ) {
198198
199199 }
200200
201201 /**
202202 * @see Filesystem::getModificationTime
203203 */
204 - public function getModificationTime($file) {
 204+ public function getModificationTime( $file ) {
205205
206206 }
207207
208208 /**
209209 * @see Filesystem::getOwner
210210 */
211 - public function getOwner($file) {
 211+ public function getOwner( $file ) {
212212
213213 }
214214
215215 /**
216216 * @see Filesystem::getSize
217217 */
218 - public function getSize($file) {
 218+ public function getSize( $file ) {
219219
220220 }
221221
222222 /**
223223 * @see Filesystem::isDir
224224 */
225 - public function isDir($path) {
 225+ public function isDir( $path ) {
226226
227227 }
228228
229229 /**
230230 * @see Filesystem::isFile
231231 */
232 - public function isFile($path) {
 232+ public function isFile( $path ) {
233233
234234 }
235235
236236 /**
237237 * @see Filesystem::isReadable
238238 */
239 - public function isReadable($file) {
 239+ public function isReadable( $file ) {
240240
241241 }
242242
243243 /**
244244 * @see Filesystem::isWritable
245245 */
246 - public function isWritable($file) {
 246+ public function isWritable( $file ) {
247247
248248 }
249249
250250 /**
251251 * @see Filesystem::listDir
252252 */
253 - public function listDir($path, $includeHidden = true, $recursive = false) {
 253+ public function listDir( $path, $includeHidden = true, $recursive = false ) {
254254
255255 }
256256
257257 /**
258258 * @see Filesystem::makeDir
259259 */
260 - public function makeDir($path, $chmod = false, $chown = false, $chgrp = false) {
 260+ public function makeDir( $path, $chmod = false, $chown = false, $chgrp = false ) {
261261
262262 }
263263
264264 /**
265265 * @see Filesystem::touch
266266 */
267 - public function touch($file, $time = 0, $atime = 0) {
 267+ public function touch( $file, $time = 0, $atime = 0 ) {
268268
269269 }
270270
271271 /**
272272 * @see Filesystem::writeToFile
273273 */
274 - public function writeToFile($file, $contents) {
 274+ public function writeToFile( $file, $contents ) {
275275
276 - }
277 -
 276+ }
 277+
278278 }
\ No newline at end of file
Index: trunk/extensions/Deployment/includes/filesystems/DirectFilesystem.php
@@ -34,63 +34,63 @@
3535 /**
3636 * @see Filesystem::changeDir
3737 */
38 - public function changeDir($dir) {
39 -
 38+ public function changeDir( $dir ) {
 39+ return @chdir( $dir );
4040 }
4141
4242 /**
4343 * @see Filesystem::changeFileGroup
4444 */
45 - public function changeFileGroup($file, $group, $recursive = false) {
 45+ public function changeFileGroup( $file, $group, $recursive = false ) {
4646
4747 }
4848
4949 /**
5050 * @see Filesystem::chmod
5151 */
52 - public function chmod($file, $mode = false, $recursive = false) {
 52+ public function chmod( $file, $mode = false, $recursive = false ) {
5353
5454 }
5555
5656 /**
5757 * @see Filesystem::chown
5858 */
59 - public function chown($file, $owner, $recursive = false) {
 59+ public function chown( $file, $owner, $recursive = false ) {
6060
6161 }
6262
6363 /**
6464 * @see Filesystem::delete
6565 */
66 - public function delete($path, $recursive = false) {
 66+ public function delete( $path, $recursive = false ) {
6767
6868 }
6969
7070 /**
7171 * @see Filesystem::doCopy
7272 */
73 - protected function doCopy($from, $to) {
 73+ protected function doCopy( $from, $to ) {
7474
7575 }
7676
7777 /**
7878 * @see Filesystem::doMove
7979 */
80 - protected function doMove($from, $to) {
 80+ protected function doMove( $from, $to ) {
8181
8282 }
8383
8484 /**
8585 * @see Filesystem::exists
8686 */
87 - public function exists($file) {
 87+ public function exists( $file ) {
8888
8989 }
9090
9191 /**
9292 * @see Filesystem::getChmod
9393 */
94 - public function getChmod($file) {
 94+ public function getChmod( $file ) {
9595
9696 }
9797
@@ -104,7 +104,7 @@
105105 /**
106106 * @see Filesystem::getCreationTime
107107 */
108 - public function getCreationTime($file) {
 108+ public function getCreationTime( $file ) {
109109
110110 }
111111
@@ -118,84 +118,84 @@
119119 /**
120120 * @see Filesystem::getGroup
121121 */
122 - public function getGroup($file) {
 122+ public function getGroup( $file ) {
123123
124124 }
125125
126126 /**
127127 * @see Filesystem::getModificationTime
128128 */
129 - public function getModificationTime($file) {
 129+ public function getModificationTime( $file ) {
130130
131131 }
132132
133133 /**
134134 * @see Filesystem::getOwner
135135 */
136 - public function getOwner($file) {
 136+ public function getOwner( $file ) {
137137
138138 }
139139
140140 /**
141141 * @see Filesystem::getSize
142142 */
143 - public function getSize($file) {
 143+ public function getSize( $file ) {
144144
145145 }
146146
147147 /**
148148 * @see Filesystem::isDir
149149 */
150 - public function isDir($path) {
 150+ public function isDir( $path ) {
151151
152152 }
153153
154154 /**
155155 * @see Filesystem::isFile
156156 */
157 - public function isFile($path) {
 157+ public function isFile( $path ) {
158158
159159 }
160160
161161 /**
162162 * @see Filesystem::isReadable
163163 */
164 - public function isReadable($file) {
 164+ public function isReadable( $file ) {
165165
166166 }
167167
168168 /**
169169 * @see Filesystem::isWritable
170170 */
171 - public function isWritable($file) {
 171+ public function isWritable( $file ) {
172172
173173 }
174174
175175 /**
176176 * @see Filesystem::listDir
177177 */
178 - public function listDir($path, $includeHidden = true, $recursive = false) {
 178+ public function listDir( $path, $includeHidden = true, $recursive = false ) {
179179
180180 }
181181
182182 /**
183183 * @see Filesystem::makeDir
184184 */
185 - public function makeDir($path, $chmod = false, $chown = false, $chgrp = false) {
 185+ public function makeDir( $path, $chmod = false, $chown = false, $chgrp = false ) {
186186
187187 }
188188
189189 /**
190190 * @see Filesystem::touch
191191 */
192 - public function touch($file, $time = 0, $atime = 0) {
 192+ public function touch( $file, $time = 0, $atime = 0 ) {
193193
194194 }
195195
196196 /**
197197 * @see Filesystem::writeToFile
198198 */
199 - public function writeToFile($file, $contents) {
 199+ public function writeToFile( $file, $contents ) {
200200
201201 }
202202

Status & tagging log