r68943 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r68942‎ | r68943 | r68944 >
Date:13:29, 3 July 2010
Author:ialex
Status:ok
Tags:
Comment:
Follow-up r68893: seems I forgot to commit those files
Modified paths:
  • /trunk/extensions/MetavidWiki/includes/articlepages/MV_DataPage.php (modified) (history)
  • /trunk/extensions/MetavidWiki/includes/articlepages/MV_StreamPage.php (modified) (history)

Diff [purge]

Index: trunk/extensions/MetavidWiki/includes/articlepages/MV_StreamPage.php
@@ -45,7 +45,7 @@
4646 return new MV_StreamPage( $article->mTitle, $mvTitle );
4747 }
4848 public function view() {
49 - global $wgRequest, $wgUser, $wgOut, $wgJsMimeType, $mvgScriptPath;
 49+ global $wgRequest, $wgUser, $wgOut;
5050 // @@TODO fix stream view() for old versions ... will likely have to replicate Article::view()
5151
5252 // include the metavid headers (for embedding video in the page)
@@ -60,7 +60,6 @@
6161 $this->outputWikiText( $text );
6262 }
6363 function outputWikiText( $text, $cache = true ) {
64 - global $wgOut, $wgUser;
6564 wfProfileIn( __METHOD__ );
6665 $MV_MetavidInterface = new MV_MetavidInterface( 'stream', $this );
6766 // will require the mv_embed script for video playback:
@@ -81,7 +80,7 @@
8281 return true;
8382 }
8483 function viewRequest() {
85 - global $wgRequest, $wgUser, $wgOut, $wgTitle;
 84+ global $wgOut, $wgTitle;
8685 // @@TODO figure out a way to be a special page but not be in the special namepsace.
8786 // namely hide the edit/discussion links and rarely cache
8887 $wgTitle->mNamespace = NS_SPECIAL;
@@ -107,7 +106,7 @@
108107 $wgOut->output();
109108 }
110109 function delete() {
111 - global $wgOut, $wgRequest, $wgUser;
 110+ global $wgOut, $wgRequest;
112111 if ( !$wgRequest->wasPosted() ) {
113112 $wgOut->addHTML( wfMsgExt( 'mv_stream_delete_warrning', 'parsemag',
114113 MV_Index::countMVDInRange( $this->mvTitle->getStreamId() ) ) );
Index: trunk/extensions/MetavidWiki/includes/articlepages/MV_DataPage.php
@@ -17,7 +17,7 @@
1818 parent::__construct( $title );
1919 }
2020 public function view() {
21 - global $wgRequest, $wgUser, $wgOut, $wgJsMimeType, $mvgScriptPath;
 21+ global $wgRequest, $wgUser, $wgOut;
2222
2323 // copied from CategoryPage ...
2424 $diff = $wgRequest->getVal( 'diff' );

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r68893Removed some unused globalsialex17:37, 2 July 2010

Status & tagging log