r68889 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r68888‎ | r68889 | r68890 >
Date:16:40, 2 July 2010
Author:jeroendedauw
Status:deferred
Tags:
Comment:
Added list support for the KML parameter for Google Maps
Modified paths:
  • /trunk/extensions/SemanticMaps/SemanticMaps.php (modified) (history)
  • /trunk/extensions/SemanticMaps/Services/GoogleMaps/SM_GoogleMapsFormInput.php (modified) (history)
  • /trunk/extensions/SemanticMaps/Services/GoogleMaps/SM_GoogleMapsQP.php (modified) (history)

Diff [purge]

Index: trunk/extensions/SemanticMaps/Services/GoogleMaps/SM_GoogleMapsQP.php
@@ -90,7 +90,7 @@
9191 types: [$this->types],
9292 controls: [$this->controls],
9393 scrollWheelZoom: $this->autozoom,
94 - kml: '$this->kml'
 94+ kml: [$this->kml]
9595 },
9696 [$markersString]
9797 );
Index: trunk/extensions/SemanticMaps/Services/GoogleMaps/SM_GoogleMapsFormInput.php
@@ -99,7 +99,7 @@
100100 types: [$this->types],
101101 controls: [$this->controls],
102102 scrollWheelZoom: $this->autozoom,
103 - kml: '$this->kml'
 103+ kml: [$this->kml]
104104 },
105105 {$this->markerCoords['lat']},
106106 {$this->markerCoords['lon']}
Index: trunk/extensions/SemanticMaps/SemanticMaps.php
@@ -35,7 +35,7 @@
3636
3737 // Only initialize the extension when all dependencies are present.
3838 if ( defined( 'Maps_VERSION' ) && defined( 'SMW_VERSION' ) ) {
39 - define( 'SM_VERSION', '0.6.4 a4' );
 39+ define( 'SM_VERSION', '0.6.4 a5' );
4040
4141 $smgScriptPath = ( isset( $wgExtensionAssetsPath ) && $wgExtensionAssetsPath ? $wgExtensionAssetsPath : $wgScriptPath . '/extensions' ) . '/SemanticMaps';
4242 $smgDir = dirname( __FILE__ ) . '/';

Status & tagging log