r68850 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r68849‎ | r68850 | r68851 >
Date:20:22, 1 July 2010
Author:catrope
Status:deferred
Tags:
Comment:
1.16wmf4: Merge r63277, r63278 (CodeReview auto-deferral by regex) from trunk per Chad's request
Modified paths:
  • /branches/wmf/1.16wmf4/extensions/CodeReview (modified) (history)
  • /branches/wmf/1.16wmf4/extensions/CodeReview/CodeReview.php (modified) (history)
  • /branches/wmf/1.16wmf4/extensions/CodeReview/backend/CodeRevision.php (modified) (history)

Diff [purge]

Index: branches/wmf/1.16wmf4/extensions/CodeReview/CodeReview.php
@@ -151,6 +151,13 @@
152152 */
153153 $wgCodeReviewMaxDiffSize = 500000;
154154
 155+/**
 156+ * Any base paths matching regular expressions in this array will have their
 157+ * default status set to deferred instead of new. Helpful if you've got a part
 158+ * of the repository you don't care about.
 159+ */
 160+$wgCodeReviewDeferredPaths = array();
 161+
155162 # Schema changes
156163 $wgHooks['LoadExtensionSchemaUpdates'][] = 'efCodeReviewSchemaUpdates';
157164
Index: branches/wmf/1.16wmf4/extensions/CodeReview/backend/CodeRevision.php
@@ -41,6 +41,15 @@
4242 }
4343 }
4444 $rev->mCommonPath = $common;
 45+
 46+ // Check for ignored paths
 47+ global $wgCodeReviewDeferredPaths;
 48+ foreach( $wgCodeReviewDeferredPaths as $defer ) {
 49+ if( preg_match( $defer, $rev->mCommonPath ) ) {
 50+ $rev->mStatus = 'deferred';
 51+ break;
 52+ }
 53+ }
4554 return $rev;
4655 }
4756
Property changes on: branches/wmf/1.16wmf4/extensions/CodeReview
___________________________________________________________________
Name: svn:mergeinfo
4857 - /branches/wmf-deployment/extensions/CodeReview:60970
/trunk/extensions/CodeReview:67212
/trunk/phase3/extensions/CodeReview:63545-63546,63549,63643,63764,63897-63901,64113,64509,65387,65391,65555,65590,65650,65816
4958 + /branches/wmf-deployment/extensions/CodeReview:60970
/trunk/extensions/CodeReview:63277-63278,67212
/trunk/phase3/extensions/CodeReview:63545-63546,63549,63643,63764,63897-63901,64113,64509,65387,65391,65555,65590,65650,65816

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r63277Add new configuration variable: . Takes regexes for things you can auto-defer...demon15:28, 5 March 2010
r63278Add missing m prefix (stupid prefixes are stupid)demon15:29, 5 March 2010

Status & tagging log