r68836 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r68835‎ | r68836 | r68837 >
Date:15:29, 1 July 2010
Author:demon
Status:ok
Tags:
Comment:
Please don't use functions that were deprecated 24309 revisions before you used them
Modified paths:
  • /trunk/extensions/SocialProfile/SystemGifts/SpecialSystemGiftManagerLogo.php (modified) (history)
  • /trunk/extensions/SocialProfile/UserGifts/SpecialGiftManagerLogo.php (modified) (history)

Diff [purge]

Index: trunk/extensions/SocialProfile/SystemGifts/SpecialSystemGiftManagerLogo.php
@@ -670,7 +670,7 @@
671671 */
672672 function verify( $tmpfile, $extension ) {
673673 # magically determine mime type
674 - $magic = & wfGetMimeMagic();
 674+ $magic = MimeMagic::singleton();
675675 $mime = $magic->guessMimeType( $tmpfile, false );
676676
677677 # check mime type, if desired
@@ -714,7 +714,7 @@
715715 * @return bool
716716 */
717717 function verifyExtension( $mime, $extension ) {
718 - $magic =& wfGetMimeMagic();
 718+ $magic = MimeMagic::singleton();
719719
720720 if ( !$mime || $mime == 'unknown' || $mime == 'unknown/unknown' )
721721 if ( !$magic->isRecognizableExtension( $extension ) ) {
Index: trunk/extensions/SocialProfile/UserGifts/SpecialGiftManagerLogo.php
@@ -658,7 +658,7 @@
659659 */
660660 function verify( $tmpfile, $extension ) {
661661 # magically determine mime type
662 - $magic = & wfGetMimeMagic();
 662+ $magic = MimeMagic::singleton();
663663 $mime = $magic->guessMimeType( $tmpfile, false );
664664
665665 # check mime type, if desired
@@ -703,7 +703,7 @@
704704 * @return bool
705705 */
706706 function verifyExtension( $mime, $extension ) {
707 - $magic = & wfGetMimeMagic();
 707+ $magic = MimeMagic::singleton();
708708
709709 if ( !$mime || $mime == 'unknown' || $mime == 'unknown/unknown' )
710710 if ( !$magic->isRecognizableExtension( $extension ) ) {

Follow-up revisions

RevisionCommit summaryAuthorDate
r68837Throw a wfDeprecated() on this since the last usage is gone in r68836demon15:31, 1 July 2010

Status & tagging log