r68822 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r68821‎ | r68822 | r68823 >
Date:09:17, 1 July 2010
Author:raymond
Status:ok
Tags:
Comment:
Follow-up r68820: Fix another warning and a fatal error
Modified paths:
  • /trunk/extensions/AuthorProtect/AuthorProtect.php (modified) (history)

Diff [purge]

Index: trunk/extensions/AuthorProtect/AuthorProtect.php
@@ -96,7 +96,7 @@
9797 return true;
9898 }
9999
100 -function efAuthorProtectForm( $action, &$article ) {
 100+function efAuthorProtectForm( $action, $article ) {
101101 global $wgTitle, $wgAuthorProtectDoProtect;
102102 if ( $action == 'authorprotect' ) {
103103 wfLoadExtensionMessages( 'AuthorProtect' );
@@ -110,7 +110,7 @@
111111 if ( !$wgUser->matchEditToken( $wgRequest->getText( 'wpToken' ) ) ) {
112112 $wgOut->setPageTitle( wfMsg( 'errorpagetitle' ) );
113113 $wgOut->addWikiText( wfMsg( 'sessionfailure' ) );
114 - return;
 114+ return false;
115115 }
116116 $restrictions = array();
117117 $expiration = array();

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r68820Fix Warning: Parameter 1 to efAssignAuthor() expected to be a reference, valu...raymond08:05, 1 July 2010

Status & tagging log