r68815 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r68814‎ | r68815 | r68816 >
Date:05:52, 1 July 2010
Author:tparscal
Status:ok
Tags:
Comment:
Got styles working
Modified paths:
  • /branches/resourceloader/phase3/includes/ResourceLoader.php (modified) (history)

Diff [purge]

Index: branches/resourceloader/phase3/includes/ResourceLoader.php
@@ -54,6 +54,7 @@
5555 'bar' => array(
5656 'script' => 'resources/test/bar.js',
5757 'loader' => 'resources/test/loader.js',
 58+ 'style' => 'resources/test/bar.css',
5859 ),
5960 'buz' => array(
6061 'script' => 'resources/test/baz.js',
@@ -204,7 +205,7 @@
205206 global $wgMemc;
206207 $key = wfMemcKey( 'resourceloader', 'cssmin', md5( $css ) );
207208 $cached = $wgMemc->get( $key );
208 - if( $cached !== false ) {
 209+ if( $cached !== false && $cached !== null ) {
209210 return $cached;
210211 }
211212 // TODO: Test how well this path rewriting stuff works with various setups
@@ -217,7 +218,7 @@
218219 global $wgMemc;
219220 $key = wfMemcKey( 'resourceloader', 'cssjanus', md5( $css ) );
220221 $cached = $wgMemc->get( $key );
221 - if ( $cached !== false ) {
 222+ if ( $cached !== false && $cached !== null ) {
222223 return $cached;
223224 }
224225 $retval = $css; // TODO: Actually flip

Status & tagging log