r68759 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r68758‎ | r68759 | r68760 >
Date:03:36, 30 June 2010
Author:tstarling
Status:ok
Tags:
Comment:
* Removed mockup code from WebInstallerPage::execute(), made it abstract instead.
* Updated URL for session.save_path documentation.
* Fixed documentation typo.
Modified paths:
  • /trunk/phase3/includes/installer/LocalSettingsGenerator.php (modified) (history)
  • /trunk/phase3/includes/installer/WebInstaller.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/installer/WebInstaller.php
@@ -238,7 +238,7 @@
239239 /**
240240 * Get the value of session.save_path
241241 *
242 - * Per http://www.php.net/manual/en/ref.session.php#ini.session.save-path,
 242+ * Per http://www.php.net/manual/en/session.configuration.php#ini.session.save-path,
243243 * this might have some additional preceding parts which need to be
244244 * ditched
245245 *
@@ -803,7 +803,7 @@
804804 }
805805 }
806806
807 -class WebInstallerPage {
 807+abstract class WebInstallerPage {
808808 function __construct( $parent ) {
809809 $this->parent = $parent;
810810 }
@@ -863,15 +863,7 @@
864864 return array_search( $this->getName(), $this->parent->pageSequence );
865865 }
866866
867 - function execute() {
868 - if ( $this->parent->request->wasPosted() ) {
869 - return 'continue';
870 - } else {
871 - $this->startForm();
872 - $this->addHTML( 'Mockup' );
873 - $this->endForm();
874 - }
875 - }
 867+ abstract function execute();
876868
877869 function getVar( $var ) {
878870 return $this->parent->getVar( $var );
Index: trunk/phase3/includes/installer/LocalSettingsGenerator.php
@@ -7,7 +7,7 @@
88 private $installer;
99
1010 /**
11 - * Construtor.
 11+ * Constructor.
1212 * @param $installer Installer subclass
1313 */
1414 public function __construct( Installer $installer ) {
@@ -263,4 +263,4 @@
264264 \$wgCacheEpoch = max( \$wgCacheEpoch, gmdate( 'YmdHis', @filemtime( __FILE__ ) ) );
265265 ";
266266 }
267 -}
\ No newline at end of file
 267+}

Status & tagging log