r68716 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r68715‎ | r68716 | r68717 >
Date:09:11, 29 June 2010
Author:maxsem
Status:ok
Tags:
Comment:
Fixed a fatal installer failure on PG introduced in r67707. 1.16 is unaffected
Modified paths:
  • /trunk/phase3/includes/db/DatabasePostgres.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/db/DatabasePostgres.php
@@ -1355,7 +1355,7 @@
13561356 echo "<li>Populating interwiki table... ";
13571357 ## Avoid the non-standard "REPLACE INTO" syntax
13581358 $f = fopen( "../maintenance/interwiki.sql", 'r' );
1359 - if ( $f ) {
 1359+ if ( !$f ) {
13601360 print "<b>FAILED</b></li>";
13611361 dieout( "Could not find the interwiki.sql file" );
13621362 }

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r67707Fixed a bunch of silly instances of [^!=]==\s*(true|false)demon11:44, 9 June 2010

Status & tagging log