r68704 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r68703‎ | r68704 | r68705 >
Date:03:44, 29 June 2010
Author:tstarling
Status:ok
Tags:
Comment:
Removed the hacks from r62948 to skip ApiTest if the parser test database is currently active. This is no longer necessary since the parser tests tear down the database environment properly.
Modified paths:
  • /trunk/phase3/maintenance/tests/ApiTest.php (modified) (history)

Diff [purge]

Index: trunk/phase3/maintenance/tests/ApiTest.php
@@ -55,10 +55,8 @@
5656 }
5757
5858 function testApi() {
59 - global $wgServerName, $wgServer, $wgDBprefix, $wgDBtype;
 59+ global $wgServerName, $wgServer;
6060
61 - if ( $wgDBprefix === "parsertest_" || ( $wgDBtype == 'oracle' && $wgDBprefix === 'pt_' ) )
62 - $this->markTestSkipped( "This test can't (yet?) be run with the parser tests" );
6361 if ( !isset( $wgServerName ) || !isset( $wgServer ) ) {
6462 $this->markTestIncomplete( 'This test needs $wgServerName and $wgServer to ' .
6563 'be set in LocalSettings.php' );
@@ -73,10 +71,8 @@
7472 }
7573
7674 function testApiLoginNoName() {
77 - global $wgServerName, $wgServer, $wgDBprefix, $wgDBtype;
 75+ global $wgServerName, $wgServer;
7876
79 - if ( $wgDBprefix === "parsertest_" || ( $wgDBtype == 'oracle' && $wgDBprefix === 'pt_' ) )
80 - $this->markTestSkipped( "This test can't (yet?) be run with the parser tests" );
8177 if ( !isset( $wgServerName ) || !isset( $wgServer ) ) {
8278 $this->markTestIncomplete( 'This test needs $wgServerName and $wgServer to ' .
8379 'be set in LocalSettings.php' );
@@ -94,10 +90,8 @@
9591 }
9692
9793 function testApiLoginBadPass() {
98 - global $wgServerName, $wgServer, $wgDBprefix, $wgDBtype;
 94+ global $wgServerName, $wgServer;
9995
100 - if ( $wgDBprefix === "parsertest_" || ( $wgDBtype == 'oracle' && $wgDBprefix === 'pt_' ) )
101 - $this->markTestSkipped( "This test can't (yet?) be run with the parser tests" );
10296 if ( !isset( $wgServerName ) || !isset( $wgServer ) ) {
10397 $this->markTestIncomplete( 'This test needs $wgServerName and $wgServer to ' .
10498 'be set in LocalSettings.php' );
@@ -131,10 +125,8 @@
132126 }
133127
134128 function testApiLoginGoodPass() {
135 - global $wgServerName, $wgServer, $wgDBprefix, $wgDBtype;
 129+ global $wgServerName, $wgServer;
136130
137 - if ( $wgDBprefix === "parsertest_" || ( $wgDBtype == 'oracle' && $wgDBprefix === 'pt_' ) )
138 - $this->markTestSkipped( "This test can't (yet?) be run with the parser tests" );
139131 if ( !isset( $wgServerName ) || !isset( $wgServer ) ) {
140132 $this->markTestIncomplete( 'This test needs $wgServerName and $wgServer to ' .
141133 'be set in LocalSettings.php' );
@@ -171,10 +163,8 @@
172164 }
173165
174166 function testApiGotCookie() {
175 - global $wgServerName, $wgServer, $wgScriptPath, $wgDBprefix, $wgDBtype;
 167+ global $wgServerName, $wgServer, $wgScriptPath;
176168
177 - if ( $wgDBprefix === "parsertest_" || ( $wgDBtype == 'oracle' && $wgDBprefix === 'pt_' ) )
178 - $this->markTestSkipped( "This test can't (yet?) be run with the parser tests" );
179169 if ( !isset( $wgServerName ) || !isset( $wgServer ) ) {
180170 $this->markTestIncomplete( 'This test needs $wgServerName and $wgServer to ' .
181171 'be set in LocalSettings.php' );
@@ -214,10 +204,8 @@
215205 */
216206 function testApiListPages( CookieJar $cj ) {
217207 $this->markTestIncomplete( "Not done with this yet" );
218 - global $wgServerName, $wgServer, $wgDBprefix, $wgDBtype;
 208+ global $wgServerName, $wgServer;
219209
220 - if ( $wgDBprefix === "parsertest_" || ( $wgDBtype == 'oracle' && $wgDBprefix === 'pt_' ) )
221 - $this->markTestSkipped( "This test can't (yet?) be run with the parser tests" );
222210 if ( $wgServerName == "localhost" || $wgServer == "http://localhost" ) {
223211 $this->markTestIncomplete( 'This test needs $wgServerName and $wgServer to ' .
224212 'be set in LocalSettings.php' );

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r62948* Make tests work better together. Tests are now skipped or marked incomplete....mah04:37, 25 February 2010

Status & tagging log