r68670 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r68669‎ | r68670 | r68671 >
Date:17:51, 28 June 2010
Author:ialex
Status:ok
Tags:
Comment:
* (bug 24155) Import no longer produces errors with php 5.2 and before
Modified paths:
  • /trunk/phase3/includes/ImportXMLReader.php (modified) (history)
  • /trunk/phase3/includes/specials/SpecialImport.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/ImportXMLReader.php
@@ -174,7 +174,8 @@
175175 * Mostly for hook use
176176 */
177177 public function finishImportPage( $title, $origTitle, $revCount, $sRevCount, $pageInfo ) {
178 - return wfRunHooks( 'AfterImportPage', func_get_args() );
 178+ $args = func_get_args();
 179+ return wfRunHooks( 'AfterImportPage', $args );
179180 }
180181
181182 /**
@@ -213,7 +214,8 @@
214215 */
215216 private function pageOutCallback( $title, $origTitle, $revCount, $sucCount, $pageInfo ) {
216217 if( isset( $this->mPageOutCallback ) ) {
217 - call_user_func_array( $this->mPageOutCallback, func_get_args() );
 218+ $args = func_get_args();
 219+ call_user_func_array( $this->mPageOutCallback, $args );
218220 }
219221 }
220222
Index: trunk/phase3/includes/specials/SpecialImport.php
@@ -304,7 +304,8 @@
305305 function reportPage( $title, $origTitle, $revisionCount, $successCount ) {
306306 global $wgOut, $wgUser, $wgLang, $wgContLang;
307307
308 - call_user_func_array( $this->mOriginalPageOutCallback, func_get_args() );
 308+ $args = func_get_args();
 309+ call_user_func_array( $this->mOriginalPageOutCallback, $args );
309310
310311 $skin = $wgUser->getSkin();
311312

Status & tagging log