r68560 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r68559‎ | r68560 | r68561 >
Date:10:58, 25 June 2010
Author:tstarling
Status:ok
Tags:
Comment:
Run texvc via wfShellExec(), so that execution time is limited.
Modified paths:
  • /trunk/phase3/RELEASE-NOTES (modified) (history)
  • /trunk/phase3/includes/Math.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/Math.php
@@ -72,7 +72,7 @@
7373 }
7474
7575 wfDebug( "TeX: $cmd\n" );
76 - $contents = `$cmd`;
 76+ $contents = wfShellExec( $cmd );
7777 wfDebug( "TeX output:\n $contents\n---\n" );
7878
7979 if (strlen($contents) == 0) {
Index: trunk/phase3/RELEASE-NOTES
@@ -92,6 +92,7 @@
9393 * (bug 21477) \& can now be used in <math>
9494 * (bug 11641) \dotsc \dotsm \dotsi \dotso can now be used in <math>
9595 * (bug 21475) \mathtt and \textsf can now be used in <math>
 96+* texvc is now run via ulimit4.sh, to limit execution time.
9697
9798 === Bug fixes in 1.17 ===
9899 * (bug 17560) Half-broken deletion moved image files to deletion archive

Status & tagging log