r68550 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r68549‎ | r68550 | r68551 >
Date:03:44, 25 June 2010
Author:laner
Status:deferred
Tags:
Comment:
Fixed $wgLDAPAutoAuthUsername check, and uncommented the MEDIAWIKI check, per r68501 comments
Modified paths:
  • /trunk/extensions/LdapAuthentication/LdapAuthentication.php (modified) (history)

Diff [purge]

Index: trunk/extensions/LdapAuthentication/LdapAuthentication.php
@@ -39,7 +39,7 @@
4040 # Support is available at http://www.mediawiki.org/wiki/Extension_talk:LDAP_Authentication
4141 #
4242
43 -//if ( !defined( 'MEDIAWIKI' ) ) exit;
 43+if ( !defined( 'MEDIAWIKI' ) ) exit;
4444
4545 $wgLDAPDomainNames = array();
4646 $wgLDAPServerNames = array();
@@ -1845,7 +1845,7 @@
18461846 $wgLDAPAutoAuthDomain = $wgLDAPSmartcardDomain;
18471847 }
18481848
1849 - if ( $wgLDAPAutoAuthUsername != "" ) {
 1849+ if ( $wgLDAPAutoAuthUsername !== "" ) {
18501850 $wgAuth->printDebug( "wgLDAPAutoAuthUsername is not null, adding hooks.", NONSENSITIVE );
18511851 if ( version_compare( $wgVersion, '1.14.0', '<' ) ) {
18521852 if ( version_compare( $wgVersion, '1.13.0', '<' ) ) {

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r68501* Fixed issue with single domains, and non-auto-authentication domains being ...laner03:04, 24 June 2010

Status & tagging log