r68526 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r68525‎ | r68526 | r68527 >
Date:19:11, 24 June 2010
Author:juliano
Status:deferred
Tags:
Comment:
Fix usage of old deprecated functions.
Modified paths:
  • /trunk/extensions/Wikilog/WikilogCommentsPage.php (modified) (history)
  • /trunk/extensions/Wikilog/WikilogItemPager.php (modified) (history)
  • /trunk/extensions/Wikilog/WikilogMainPage.php (modified) (history)

Diff [purge]

Index: trunk/extensions/Wikilog/WikilogItemPager.php
@@ -490,12 +490,14 @@
491491 case 'wlw_title':
492492 $page = $this->mCurrentItem->mParentTitle;
493493 $text = $this->mCurrentItem->mParentName;
494 - return $this->getSkin()->makeKnownLinkObj( $page, $text );
 494+ return $this->getSkin()->link( $page, $text, array(), array(),
 495+ array( 'known', 'noclasses' ) );
495496
496497 case 'wlp_title':
497498 $page = $this->mCurrentItem->mTitle;
498499 $text = $this->mCurrentItem->mName;
499 - $s = $this->getSkin()->makeKnownLinkObj( $page, $text );
 500+ $s = $this->getSkin()->link( $page, $text, array(), array(),
 501+ array( 'known', 'noclasses' ) );
500502 if ( !$this->mCurrentRow->wlp_publish ) {
501503 $draft = wfMsg( 'wikilog-draft-title-mark' );
502504 $s = Xml::wrapClass( "$s $draft", 'wl-draft-inline' );
@@ -505,7 +507,8 @@
506508 case 'wlp_num_comments':
507509 $page = $this->mCurrentItem->mTitle->getTalkPage();
508510 $text = $this->mCurrentItem->getNumComments();
509 - return $this->getSkin()->makeKnownLinkObj( $page, $text );
 511+ return $this->getSkin()->link( $page, $text, array(), array(),
 512+ array( 'known', 'noclasses' ) );
510513
511514 case '_wl_actions':
512515 if ( $this->mCurrentItem->mTitle->quickUserCan( 'edit' ) ) {
@@ -570,7 +573,7 @@
571574 private function authorLink( $name ) {
572575 $skin = $this->getSkin();
573576 $title = Title::makeTitle( NS_USER, $name );
574 - return $skin->makeLinkObj( $title, $name );
 577+ return $skin->link( $title, $name );
575578 }
576579
577580 /**
Index: trunk/extensions/Wikilog/WikilogMainPage.php
@@ -46,6 +46,7 @@
4747 public $mWikilogIcon = false;
4848 public $mWikilogLogo = false;
4949 public $mWikilogAuthors = false;
 50+ public $mWikilogUpdated = false;
5051 public $mWikilogPubdate = false;
5152
5253 /**
@@ -172,7 +173,7 @@
173174 );
174175 }
175176 $s .= Xml::tags( 'div', array( 'class' => 'wl-title' ),
176 - $skin->makeKnownLinkObj( $this->mTitle ) );
 177+ $skin->link( $this->mTitle, null, array(), array(), array( 'known', 'noclasses' ) ) );
177178
178179 $st =& $this->mWikilogSubtitle;
179180 if ( is_array( $st ) ) {
@@ -221,14 +222,11 @@
222223 global $wgWikilogFeedClasses;
223224
224225 // Uses messages 'wikilog-post-count-published', 'wikilog-post-count-drafts', 'wikilog-post-count-all'
225 - $s = $skin->makeKnownLinkObj(
226 - $this->mTitle,
227 - wfMsgExt(
228 - "wikilog-post-count-{$type}",
229 - array( 'parsemag' ),
230 - $num
231 - ),
232 - "view=archives&show={$type}"
 226+ $s = $skin->link( $this->mTitle,
 227+ wfMsgExt( "wikilog-post-count-{$type}", array( 'parsemag' ), $num ),
 228+ array(),
 229+ array( 'view' => "archives", 'show' => $type ),
 230+ array( 'knwon', 'noclasses' )
233231 );
234232 if ( !empty( $wgWikilogFeedClasses ) ) {
235233 $f = array();
@@ -237,7 +235,7 @@
238236 wfMsg( "feed-{$format}" ),
239237 array( 'class' => "feedlink", 'type' => "application/{$format}+xml" ),
240238 array( 'view' => "archives", 'show' => $type, 'feed' => $format ),
241 - 'known'
 239+ array( 'known', 'noclasses' )
242240 );
243241 }
244242 $s .= ' (' . implode( ', ', $f ) . ')';
Index: trunk/extensions/Wikilog/WikilogCommentsPage.php
@@ -328,8 +328,10 @@
329329 );
330330 } else {
331331 $loginTitle = SpecialPage::getTitleFor( 'Userlogin' );
332 - $loginLink = $this->mSkin->makeKnownLinkObj( $loginTitle,
333 - wfMsgHtml( 'loginreqlink' ), 'returnto=' . $wgTitle->getPrefixedUrl() );
 332+ $loginLink = $this->mSkin->link( $loginTitle,
 333+ wfMsgHtml( 'loginreqlink' ), array(),
 334+ array( 'returnto' => $wgTitle->getPrefixedUrl() )
 335+ );
334336 $message = wfMsg( 'wikilog-posting-anonymously', $loginLink );
335337 $fields[] = array(
336338 Xml::label( wfMsg( 'wikilog-form-name' ), 'wl-name' ),

Status & tagging log