r68509 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r68508‎ | r68509 | r68510 >
Date:11:01, 24 June 2010
Author:ning
Status:deferred
Tags:
Comment:
Bug fix: UI script adjustment
Modified paths:
  • /trunk/extensions/SemanticNotifyMe/scripts/NotifyMe/NotifyHelper.js (modified) (history)
  • /trunk/extensions/SemanticNotifyMe/specials/SMWNotifyMe/SMWNotifyMe.php (modified) (history)

Diff [purge]

Index: trunk/extensions/SemanticNotifyMe/specials/SMWNotifyMe/SMWNotifyMe.php
@@ -340,7 +340,7 @@
341341 $showall = $dbr->selectField( 'smw_nm_query', 'show_all', array( 'notify_id' => $id ), 'NotifyMeRSS' );
342342 if ( $showall ) {
343343 $query = $dbr->selectField( 'smw_nm_query', 'query', array( 'notify_id' => $id ), 'NotifyMeRSS' );
344 - SMWQueryProcessor::processFunctionParams( explode( "\n", $query ), $querystring, $params, $printouts );
 344+ SMWQueryProcessor::processFunctionParams( SMWNotifyProcessor::getQueryRawParams( $query ), $querystring, $params, $printouts );
345345 $query = SMWQueryProcessor::createQuery( $querystring, $params, SMWQueryProcessor::INLINE_QUERY, 'auto', $printouts );
346346 $res = smwfGetStore()->getQueryResult( $query );
347347
Index: trunk/extensions/SemanticNotifyMe/scripts/NotifyMe/NotifyHelper.js
@@ -117,7 +117,7 @@
118118 ntr.appendChild(td);
119119 item = document.createElement("a");
120120 td.appendChild(item);
121 - item.href = "index.php?title=Special:NotifyMe&feed=rss&nid=" + nid;
 121+ item.href = wgScript + "?title=Special:NotifyMe&feed=rss&nid=" + nid;
122122 item.target = "_blank";
123123 item.innerHTML = $('nmqname').value;
124124
@@ -170,7 +170,7 @@
171171 }
172172
173173 $('nmtoolbar').parentNode.insertBefore(ntr, $('nmtoolbar'));
174 - attachAutocompleteToField("nmd_" + nid);
 174+ nmAttachAutocompleteToField("nmd_" + nid);
175175 },
176176
177177 doUpdateMail:function() {

Status & tagging log