r68484 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r68483‎ | r68484 | r68485 >
Date:19:49, 23 June 2010
Author:reedy
Status:ok
Tags:
Comment:
Minor followup to r68482, fix the fail I introduced

+ 1 minor improvement to reused method
Modified paths:
  • /trunk/phase3/includes/api/ApiQueryAllLinks.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/api/ApiQueryAllLinks.php
@@ -186,10 +186,10 @@
187187 return array(
188188 'from' => 'The page title to start enumerating from',
189189 'prefix' => 'Search for all page titles that begin with this value',
190 - 'unique' => "Only show unique links. Cannot be used with generator or {p}prop=ids",
 190+ 'unique' => "Only show unique links. Cannot be used with generator or {$p}prop=ids",
191191 'prop' => array(
192192 'What pieces of information to include',
193 - " ids - Adds pageid of where the link is from (Cannot be used with {p}unique)",
 193+ " ids - Adds pageid of where the link is from (Cannot be used with {$p}unique)",
194194 ' title - Adds the title of the link',
195195 ),
196196 'namespace' => 'The namespace to enumerate',
@@ -203,9 +203,10 @@
204204 }
205205
206206 public function getPossibleErrors() {
 207+ $m = $this->getModuleName();
207208 return array_merge( parent::getPossibleErrors(), array(
208 - array( 'code' => 'params', 'info' => $this->getModuleName() . ' cannot be used as a generator in unique links mode' ),
209 - array( 'code' => 'params', 'info' => $this->getModuleName() . ' cannot return corresponding page ids in unique links mode' ),
 209+ array( 'code' => 'params', 'info' => "{$m} cannot be used as a generator in unique links mode" ),
 210+ array( 'code' => 'params', 'info' => "{$m} cannot return corresponding page ids in unique links mode" ),
210211 array( 'code' => 'params', 'info' => 'alcontinue and alfrom cannot be used together' ),
211212 array( 'code' => 'badcontinue', 'info' => 'Invalid continue parameter' ),
212213 ) );

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r68482* (bug 23473) - Give description of properties on all modules...reedy19:36, 23 June 2010

Status & tagging log