r68472 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r68471‎ | r68472 | r68473 >
Date:18:55, 23 June 2010
Author:nikerabbit
Status:ok
Tags:
Comment:
Fixed filtering, which would fail if no messages were tagged for given filter
Modified paths:
  • /trunk/extensions/Translate/MessageCollection.php (modified) (history)

Diff [purge]

Index: trunk/extensions/Translate/MessageCollection.php
@@ -196,6 +196,7 @@
197197 if ( $filter !== 'optional' && $filter !== 'ignored' ) {
198198 throw new MWException( "No tagged messages for custom filter $filter" );
199199 }
 200+ $keys = array();
200201 } else {
201202 $taggedKeys = array_flip( $this->tags[$filter] );
202203 $keys = $this->filterOnCondition( $keys, $taggedKeys, $condition );

Follow-up revisions

RevisionCommit summaryAuthorDate
r68486Fix the filtering properly this time (fixes r68472)nikerabbit20:30, 23 June 2010

Status & tagging log