r68429 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r68428‎ | r68429 | r68430 >
Date:21:19, 22 June 2010
Author:tparscal
Status:ok
Tags:
Comment:
Added a comment about where we need to set the config on initial load
Modified paths:
  • /branches/resourceloader/phase3/includes/ResourceLoader.php (modified) (history)

Diff [purge]

Index: branches/resourceloader/phase3/includes/ResourceLoader.php
@@ -119,6 +119,16 @@
120120 $this->loadedModules = array_unique( $this->loadedModules );
121121 $retval = '';
122122
 123+ /*
 124+ * Skin::makeGlobalVariablesScript needs to be modified so that we still output the globals for now, but also
 125+ * put them into the initial payload like this:
 126+ *
 127+ * // Sets the inital configuration
 128+ * mw.config.set( { 'name': 'value', ... } );
 129+ *
 130+ * Also, the naming of these variables is horrible and sad, hopefully this can be worked on
 131+ */
 132+
123133 foreach ( $this->scripts as $script ) {
124134 // TODO: file_get_contents() errors?
125135 // TODO: CACHING!

Status & tagging log