r68423 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r68422‎ | r68423 | r68424 >
Date:18:31, 22 June 2010
Author:tparscal
Status:ok
Tags:
Comment:
No need to make the mw object have private members and functions
Modified paths:
  • /branches/resourceloader/phase3/resources/mw/mw.js (modified) (history)

Diff [purge]

Index: branches/resourceloader/phase3/resources/mw/mw.js
@@ -2,14 +2,14 @@
33 * Core MediaWiki JavaScript Library
44 */
55
6 -window.mw = new ( function() {
 6+window.mw = {
77
88 /* Public Members */
99
1010 /**
1111 * Localization system
1212 */
13 - this.msg = new ( function() {
 13+ 'msg': new ( function() {
1414
1515 /* Private Members */
1616
@@ -34,11 +34,11 @@
3535 return messages[key];
3636 }
3737 };
38 - } )();
 38+ } )(),
3939 /**
4040 * Loader system
4141 */
42 - this.loader = new ( function() {
 42+ 'loader': new ( function() {
4343
4444 /* Private Members */
4545
@@ -250,5 +250,5 @@
251251 work();
252252 }
253253 };
254 - } )();
255 -} )();
 254+ } )()
 255+};

Status & tagging log