r68412 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r68411‎ | r68412 | r68413 >
Date:16:44, 22 June 2010
Author:ialex
Status:ok
Tags:
Comment:
Removed unused or duplicate global declarations
Modified paths:
  • /trunk/extensions/ImageTagging/ImageTagging.php (modified) (history)
  • /trunk/extensions/LanguageSelector/LanguageSelector.php (modified) (history)

Diff [purge]

Index: trunk/extensions/LanguageSelector/LanguageSelector.php
@@ -96,7 +96,7 @@
9797 function wfLanguageSelectorExtension() {
9898 wfLoadExtensionMessages( 'LanguageSelector' );
9999 global $wgLanguageSelectorLanguages, $wgLanguageSelectorDetectLanguage, $wgLanguageSelectorRequestedLanguage, $wgLanguageSelectorLocation, $wgLanguageSelectorShowAll;
100 - global $wgUser, $wgLang, $wgRequest, $wgCookiePrefix, $wgCookiePath, $wgOut, $wgJsMimeType, $wgHooks;
 100+ global $wgUser, $wgLang, $wgRequest, $wgCookiePrefix, $wgCookiePath, $wgHooks;
101101
102102 $wgHooks['ParserFirstCallInit'][] = 'wfLanguageSelectorSetHook';
103103
Index: trunk/extensions/ImageTagging/ImageTagging.php
@@ -393,7 +393,6 @@
394394
395395 wfProfileIn( __METHOD__ );
396396
397 - global $wgJsMimeType, $wgScriptPath;
398397 $wgOut->addScript("<script type=\"{$wgJsMimeType}\" src=\"$wgScriptPath/extensions/ImageTagging/img_tagging.js?$wgStyleVersion\"></script>\n" );
399398 $wgOut->addScript("<script type=\"{$wgJsMimeType}\" src=\"$wgScriptPath/extensions/ImageTagging/json.js?$wgStyleVersion\"></script>\n" );
400399

Status & tagging log