r68407 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r68406‎ | r68407 | r68408 >
Date:15:38, 22 June 2010
Author:adam
Status:ok
Tags:
Comment:
SimpleSearch - removing the click handler from the input field which was causing undesirable behavior. Also, recombining from my last commit
Modified paths:
  • /trunk/extensions/UsabilityInitiative/UsabilityInitiative.hooks.php (modified) (history)
  • /trunk/extensions/UsabilityInitiative/Vector/Modules/SimpleSearch/SimpleSearch.js (modified) (history)
  • /trunk/extensions/UsabilityInitiative/Vector/Vector.combined.js (modified) (history)
  • /trunk/extensions/UsabilityInitiative/Vector/Vector.combined.min.js (modified) (history)
  • /trunk/extensions/UsabilityInitiative/Vector/Vector.hooks.php (modified) (history)
  • /trunk/extensions/UsabilityInitiative/WikiEditor/WikiEditor.hooks.php (modified) (history)
  • /trunk/extensions/UsabilityInitiative/js/plugins.combined.js (modified) (history)
  • /trunk/extensions/UsabilityInitiative/js/plugins.combined.min.js (modified) (history)

Diff [purge]

Index: trunk/extensions/UsabilityInitiative/Vector/Modules/SimpleSearch/SimpleSearch.js
@@ -115,7 +115,7 @@
116116 positionFromLeft: $j( 'body' ).is( '.rtl' ),
117117 highlightInput: true
118118 } )
119 - .bind( 'paste cut click', function() {
 119+ .bind( 'paste cut', function() {
120120 $j( this ).trigger( 'keypress' );
121121 } );
122122 $j( '#searchInput' ).suggestions( {
@@ -153,7 +153,7 @@
154154 },
155155 $region: $j( '#simpleSearch' )
156156 } )
157 - .bind( 'paste cut click', function() {
 157+ .bind( 'paste cut', function() {
158158 $j( this ).trigger( 'keypress' );
159159 } );
160160 });
Index: trunk/extensions/UsabilityInitiative/Vector/Vector.hooks.php
@@ -17,13 +17,13 @@
1818 array( 'src' => 'Modules/ExpandableSearch/ExpandableSearch.js', 'version' => 5 ),
1919 array( 'src' => 'Modules/EditWarning/EditWarning.js', 'version' => 9 ),
2020 array( 'src' => 'Modules/FooterCleanup/FooterCleanup.js', 'version' => 5 ),
21 - array( 'src' => 'Modules/SimpleSearch/SimpleSearch.js', 'version' => 19 ),
 21+ array( 'src' => 'Modules/SimpleSearch/SimpleSearch.js', 'version' => 20 ),
2222 ),
2323 'combined' => array(
24 - array( 'src' => 'Vector.combined.js', 'version' => 57 ),
 24+ array( 'src' => 'Vector.combined.js', 'version' => 59 ),
2525 ),
2626 'minified' => array(
27 - array( 'src' => 'Vector.combined.min.js', 'version' => 58 ),
 27+ array( 'src' => 'Vector.combined.min.js', 'version' => 60 ),
2828 ),
2929 );
3030 static $modules = array(
Index: trunk/extensions/UsabilityInitiative/Vector/Vector.combined.js
@@ -620,7 +620,7 @@
621621 positionFromLeft: $j( 'body' ).is( '.rtl' ),
622622 highlightInput: true
623623 } )
624 - .bind( 'paste cut click', function() {
 624+ .bind( 'paste cut', function() {
625625 $j( this ).trigger( 'keypress' );
626626 } );
627627 $j( '#searchInput' ).suggestions( {
@@ -658,7 +658,7 @@
659659 },
660660 $region: $j( '#simpleSearch' )
661661 } )
662 - .bind( 'paste cut click', function() {
 662+ .bind( 'paste cut', function() {
663663 $j( this ).trigger( 'keypress' );
664664 } );
665665 });
Index: trunk/extensions/UsabilityInitiative/Vector/Vector.combined.min.js
@@ -28,5 +28,5 @@
2929 var mod={'browsers':{'ltr':{'opera':[['>=',9.6]],'blackberry':false,'ipod':false,'iphone':false},'rtl':{'opera':[['>=',9.6]],'blackberry':false,'ipod':false,'iphone':false}}};if(!$j.wikiEditor.isSupported(mod)){return true;}
3030 $j('div#simpleSearch > input#searchInput').each(function(){$j('<label />').text(mw.usability.getMsg('vector-simplesearch-search')).css({'display':'none','position':'absolute','color':'#999999','cursor':'text','margin':'0 4px','top':'6px','line-height':'13px'}).css(($j('body').is('.rtl')?'right':'left'),0).mousedown(function(){$j(this).parent().find('input#searchInput').focus();return false;}).appendTo($j(this).parent());if($j(this).val()==''){$j(this).parent().find('label').fadeIn(100);}}).bind('keypress',function(){if($j(this).parent().find('label:visible').size()>0)
3131 $j(this).parent().find('label').fadeOut(100);}).focus(function(){$j(this).parent().find('label').fadeOut(100);}).blur(function(){if($j(this).val()==''){$j(this).parent().find('label').fadeIn(100);}});$j(document).bind('dragend',function(event){if($j('div#simpleSearch > label:visible').size()>0&&$j('div#simpleSearch > input#searchInput').val().length>0)
32 -$j('div#simpleSearch > label').fadeOut(100);});$j('#searchInput, #searchInput2, #powerSearchText, #searchText').suggestions({fetch:function(query){var $this=$j(this);var request=$j.ajax({url:wgScriptPath+'/api.php',data:{'action':'opensearch','search':query,'namespace':0,'suggest':''},dataType:'json',success:function(data){$this.suggestions('suggestions',data[1]);}});$j(this).data('request',request);},cancel:function(){var request=$j(this).data('request');if(request&&typeof request.abort=='function'){request.abort();$j(this).removeData('request');}},result:{select:function($textbox){$textbox.closest('form').submit();}},delay:120,positionFromLeft:$j('body').is('.rtl'),highlightInput:true}).bind('paste cut click',function(){$j(this).trigger('keypress');});$j('#searchInput').suggestions({result:{select:function($textbox){$textbox.closest('form').submit();}},special:{render:function(query){if($j(this).children().size()==0){$j(this).show()
33 -$label=$j('<div />').addClass('special-label').text(mw.usability.getMsg('vector-simplesearch-containing')).appendTo($j(this));$query=$j('<div />').addClass('special-query').text(query).appendTo($j(this));$query.autoEllipsis();}else{$j(this).find('.special-query').empty().text(query).autoEllipsis();}},select:function($textbox){$textbox.closest('form').append($j('<input />').attr({'type':'hidden','name':'fulltext','value':1}));$textbox.closest('form').submit();}},$region:$j('#simpleSearch')}).bind('paste cut click',function(){$j(this).trigger('keypress');});});
\ No newline at end of file
 32+$j('div#simpleSearch > label').fadeOut(100);});$j('#searchInput, #searchInput2, #powerSearchText, #searchText').suggestions({fetch:function(query){var $this=$j(this);var request=$j.ajax({url:wgScriptPath+'/api.php',data:{'action':'opensearch','search':query,'namespace':0,'suggest':''},dataType:'json',success:function(data){$this.suggestions('suggestions',data[1]);}});$j(this).data('request',request);},cancel:function(){var request=$j(this).data('request');if(request&&typeof request.abort=='function'){request.abort();$j(this).removeData('request');}},result:{select:function($textbox){$textbox.closest('form').submit();}},delay:120,positionFromLeft:$j('body').is('.rtl'),highlightInput:true}).bind('paste cut',function(){$j(this).trigger('keypress');});$j('#searchInput').suggestions({result:{select:function($textbox){$textbox.closest('form').submit();}},special:{render:function(query){if($j(this).children().size()==0){$j(this).show()
 33+$label=$j('<div />').addClass('special-label').text(mw.usability.getMsg('vector-simplesearch-containing')).appendTo($j(this));$query=$j('<div />').addClass('special-query').text(query).appendTo($j(this));$query.autoEllipsis();}else{$j(this).find('.special-query').empty().text(query).autoEllipsis();}},select:function($textbox){$textbox.closest('form').append($j('<input />').attr({'type':'hidden','name':'fulltext','value':1}));$textbox.closest('form').submit();}},$region:$j('#simpleSearch')}).bind('paste cut',function(){$j(this).trigger('keypress');});});
\ No newline at end of file
Index: trunk/extensions/UsabilityInitiative/UsabilityInitiative.hooks.php
@@ -30,11 +30,11 @@
3131 array( 'src' => 'css/vector/jquery-ui-1.7.2.css', 'version' => '1.7.2y' ),
3232 ),
3333 'combined' => array(
34 - array( 'src' => 'css/combined.css', 'version' => 107 ),
 34+ array( 'src' => 'css/combined.css', 'version' => 108 ),
3535 array( 'src' => 'css/vector/jquery-ui-1.7.2.css', 'version' => '1.7.2y' ),
3636 ),
3737 'minified' => array(
38 - array( 'src' => 'css/combined.min.css', 'version' => 107 ),
 38+ array( 'src' => 'css/combined.min.css', 'version' => 108 ),
3939 array( 'src' => 'css/vector/jquery-ui-1.7.2.css', 'version' => '1.7.2y' ),
4040 ),
4141 )
@@ -71,7 +71,7 @@
7272 array( 'src' => 'js/plugins/jquery.wikiEditor.toolbar.js', 'version' => 70 ),
7373 array( 'src' => 'js/plugins/jquery.wikiEditor.dialogs.js', 'version' => 26 ),
7474 array( 'src' => 'js/plugins/jquery.wikiEditor.toc.js', 'version' => 98 ),
75 - array( 'src' => 'js/plugins/jquery.wikiEditor.preview.js', 'version' => 11 ),
 75+ array( 'src' => 'js/plugins/jquery.wikiEditor.preview.js', 'version' => 12 ),
7676 array( 'src' => 'js/plugins/jquery.wikiEditor.templateEditor.js', 'version' => 77 ),
7777 array( 'src' => 'js/plugins/jquery.wikiEditor.templates.js', 'version' => 1 ),
7878 array( 'src' => 'js/plugins/jquery.wikiEditor.publish.js', 'version' => 5 ),
@@ -80,10 +80,10 @@
8181 array( 'src' => 'js/thirdparty/contentCollector.js', 'version' => 2 ),
8282 ),
8383 'combined' => array(
84 - array( 'src' => 'js/plugins.combined.js', 'version' => 440 ),
 84+ array( 'src' => 'js/plugins.combined.js', 'version' => 442 ),
8585 ),
8686 'minified' => array(
87 - array( 'src' => 'js/plugins.combined.min.js', 'version' => 445 ),
 87+ array( 'src' => 'js/plugins.combined.min.js', 'version' => 448 ),
8888 ),
8989 ),
9090 );
Index: trunk/extensions/UsabilityInitiative/WikiEditor/WikiEditor.hooks.php
@@ -13,7 +13,7 @@
1414 static $scripts = array(
1515 'raw' => array(
1616 array( 'src' => 'Modules/Highlight/Highlight.js', 'version' => 5 ),
17 - array( 'src' => 'Modules/Preview/Preview.js', 'version' => 7 ),
 17+ array( 'src' => 'Modules/Preview/Preview.js', 'version' => 8 ),
1818 array( 'src' => 'Modules/Publish/Publish.js', 'version' => 6 ),
1919 array( 'src' => 'Modules/Toc/Toc.js', 'version' => 7 ),
2020 array( 'src' => 'Modules/Toolbar/Toolbar.js', 'version' => 96 ),
@@ -22,10 +22,10 @@
2323 array( 'src' => 'Modules/AddMediaWizard/AddMediaWizard.js', 'version' => 6 ),
2424 ),
2525 'combined' => array(
26 - array( 'src' => 'WikiEditor.combined.js', 'version' => 104 ),
 26+ array( 'src' => 'WikiEditor.combined.js', 'version' => 106 ),
2727 ),
2828 'minified' => array(
29 - array( 'src' => 'WikiEditor.combined.min.js', 'version' => 104 ),
 29+ array( 'src' => 'WikiEditor.combined.min.js', 'version' => 106 ),
3030 ),
3131 );
3232 static $messages = array(
Index: trunk/extensions/UsabilityInitiative/js/plugins.combined.js
@@ -277,7 +277,7 @@
278278 if ( !( text in cache ) ) {
279279 cache[text] = {};
280280 }
281 - if ( !( text in matchTextCache ) ) {
 281+ if ( options.matchText && !( text in matchTextCache ) ) {
282282 matchTextCache[text] = {};
283283 }
284284 if ( options.matchText && !( options.matchText in matchTextCache[text] ) ) {
Index: trunk/extensions/UsabilityInitiative/js/plugins.combined.min.js
@@ -21,7 +21,7 @@
2222 {$.eachAsync(this,opts);return this;}})(jQuery);(function($){var cache={};var matchTextCache={};$.fn.autoEllipsis=function(options){options=$.extend({'position':'center','tooltip':false,'restoreText':false,'hasSpan':false,'matchText':null},options);$(this).each(function(){var $this=$(this);if(options.restoreText){if(!$this.data('autoEllipsis.originalText')){$this.data('autoEllipsis.originalText',$this.text());}else{$this.text($this.data('autoEllipsis.originalText'));}}
2323 var $container=$this;var $trimmableText=null;var $protectedText=null;if(options.matchText){var text=$this.text();var matchedText=options.matchText;$trimmableText=$('<span />').css('whiteSpace','nowrap').addClass('autoellipsis-trimmed').text($this.text().substr(matchedText.length,$this.text().length));$protectedText=$('<span />').addClass('autoellipsis-matched').css('whiteSpace','nowrap').text(options.matchText);$container.empty().append($protectedText).append($trimmableText);}else{if(options.hasSpan){$trimmableText=$this.children(options.selector);}else{$trimmableText=$('<span />').css('whiteSpace','nowrap').text($this.text());$this.empty().append($trimmableText);}}
2424 var text=$container.text();var trimmableText=$trimmableText.text();var w=$container.width();var pw=$protectedText?$protectedText.width():0;if(!(text in cache)){cache[text]={};}
25 -if(!(text in matchTextCache)){matchTextCache[text]={};}
 25+if(options.matchText&&!(text in matchTextCache)){matchTextCache[text]={};}
2626 if(options.matchText&&!(options.matchText in matchTextCache[text])){matchTextCache[text][options.matchText]={};}
2727 if(!options.matchText&&w in cache[text]){$container.html(cache[text][w]);if(options.tooltip)
2828 $container.attr('title',text);return;}

Status & tagging log