r68341 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r68340‎ | r68341 | r68342 >
Date:22:24, 20 June 2010
Author:hartman
Status:ok
Tags:
Comment:
Follow up r66566. Rename uploadLink() to getUploadLink() per Bryan's comments
Modified paths:
  • /trunk/phase3/includes/Skin.php (modified) (history)
  • /trunk/phase3/skins/CologneBlue.php (modified) (history)
  • /trunk/phase3/skins/Nostalgia.php (modified) (history)
  • /trunk/phase3/skins/Standard.php (modified) (history)

Diff [purge]

Index: trunk/phase3/skins/CologneBlue.php
@@ -308,7 +308,7 @@
309309 . $sep . $this->specialLink( 'listfiles' )
310310 . $sep . $this->specialLink( 'statistics' );
311311 if( UploadBase::isEnabled() && UploadBase::isAllowed( $wgUser ) === true ) {
312 - $s .= $sep . $this->uploadLink();
 312+ $s .= $sep . $this->getUploadLink();
313313 }
314314
315315 global $wgSiteSupportPage;
Index: trunk/phase3/skins/Standard.php
@@ -265,7 +265,7 @@
266266 }
267267
268268 if( UploadBase::isEnabled() && UploadBase::isAllowed( $wgUser ) === true ) {
269 - $s .= $this->uploadLink() . $sep;
 269+ $s .= $this->getUploadLink() . $sep;
270270 }
271271
272272 $s .= $this->specialLink( 'specialpages' );
Index: trunk/phase3/skins/Nostalgia.php
@@ -90,7 +90,7 @@
9191 $s .= $sep . $this->specialLink( 'preferences' );
9292 /* show upload file link */
9393 if( UploadBase::isEnabled() && UploadBase::isAllowed( $wgUser ) === true ) {
94 - $s .= $sep . $this->uploadLink();
 94+ $s .= $sep . $this->getUploadLink();
9595 }
9696
9797 /* show log out link */
Index: trunk/phase3/includes/Skin.php
@@ -1989,7 +1989,7 @@
19901990 );
19911991 }
19921992
1993 - function uploadLink() {
 1993+ function getUploadLink() {
19941994 global $wgUploadNavigationUrl;
19951995
19961996 if( $wgUploadNavigationUrl ) {

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r66566Let old skins take into account $wgUploadNavigationUrl....hartman15:15, 17 May 2010

Status & tagging log