r68284 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r68283‎ | r68284 | r68285 >
Date:19:35, 19 June 2010
Author:laner
Status:ok
Tags:
Comment:
Fixing compatibility with php 5.3
Modified paths:
  • /trunk/extensions/Plotters/Plotters.php (modified) (history)

Diff [purge]

Index: trunk/extensions/Plotters/Plotters.php
@@ -60,7 +60,7 @@
6161 "/plotkit/Canvas.js", "/plotkit/SweetCanvas.js" )
6262 );
6363
64 -function wfPlottersArticleSaveComplete( &$article, &$wgUser, &$text ) {
 64+function wfPlottersArticleSaveComplete( $article, $wgUser, $text ) {
6565 // update cache if MediaWiki:Plotters-definition was edited
6666 $title = $article->mTitle;
6767 if ( $title->getNamespace() == NS_MEDIAWIKI && $title->getText() == 'Plotters-definition' ) {
@@ -142,7 +142,7 @@
143143 return $plotters;
144144 }
145145
146 -function wfApplyPlotterCode( $code, &$out, &$done ) {
 146+function wfApplyPlotterCode( $code, $out, &$done ) {
147147 global $wgSkin, $wgJsMimeType;
148148
149149 // FIXME: stuff added via $out->addScript appears below usercss and userjs in the head tag.
@@ -173,7 +173,7 @@
174174 $wgParser->setFunctionHook( 'plot', 'initPlottersPF' );
175175 }
176176
177 -function initPlottersPF( &$parser ) {
 177+function initPlottersPF( $parser ) {
178178 $numargs = func_num_args();
179179 if ( $numargs < 2 ) {
180180 wfLoadExtensionMessages( 'Plotters' );
@@ -225,7 +225,7 @@
226226 * Hook callback that injects messages and things into the <head> tag
227227 * Does nothing if $parserOutput->mPlotterTag is not set
228228 */
229 -function PlottersParserOutput( &$outputPage, &$parserOutput ) {
 229+function PlottersParserOutput( $outputPage, $parserOutput ) {
230230 if ( !empty( $parserOutput->mPlottersTag ) ) {
231231 // Output required javascript
232232 $genericname = "generic";
@@ -257,7 +257,7 @@
258258 * We ignore langCode - parser function names can be translated but
259259 * we are not using this feature
260260 */
261 -function PlottersLanguageGetMagic( &$magicWords, $langCode ) {
 261+function PlottersLanguageGetMagic( $magicWords, $langCode ) {
262262 $magicWords['plot'] = array( 0, 'plot' );
263263 return true;
264264 }

Status & tagging log