r68126 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r68125‎ | r68126 | r68127 >
Date:17:24, 16 June 2010
Author:demon
Status:ok
Tags:
Comment:
Kill off another AjaxFunction. The only thing that ever used this was Configure, and it hasn't used it in a long time (r44266)
Modified paths:
  • /trunk/phase3/includes/AjaxFunctions.php (modified) (history)
  • /trunk/phase3/includes/DefaultSettings.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/AjaxFunctions.php
@@ -84,22 +84,6 @@
8585
8686 /**
8787 * Called in some places (currently just extensions)
88 - * to get the thumbnail URL for a given file at a given resolution.
89 - */
90 -function wfAjaxGetThumbnailUrl( $file, $width, $height ) {
91 - $file = wfFindFile( $file );
92 -
93 - if ( !$file || !$file->exists() ) {
94 - return null;
95 - }
96 -
97 - $url = $file->getThumbnail( $width, $height )->url;
98 -
99 - return $url;
100 -}
101 -
102 -/**
103 - * Called in some places (currently just extensions)
10488 * to get the URL for a given file.
10589 */
10690 function wfAjaxGetFileUrl( $file ) {
Index: trunk/phase3/includes/DefaultSettings.php
@@ -4811,7 +4811,7 @@
48124812 * List of Ajax-callable functions.
48134813 * Extensions acting as Ajax callbacks must register here
48144814 */
4815 -$wgAjaxExportList = array( 'wfAjaxGetThumbnailUrl', 'wfAjaxGetFileUrl' );
 4815+$wgAjaxExportList = array( 'wfAjaxGetFileUrl' );
48164816
48174817 /**
48184818 * Enable watching/unwatching pages using AJAX.

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r44266Fix up Configure extension logo setting handling:...werdna00:32, 6 December 2008

Status & tagging log