r68003 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r68002‎ | r68003 | r68004 >
Date:17:13, 14 June 2010
Author:catrope
Status:ok
Tags:
Comment:
UsabilityInitiative: Separate jQuery UI into a separate file and load it on-demand. This allows us to fix bug 23926 (old versions of Netscape crash when parsing jQuery UI's JS) simply by blacklisting Netscape < 9.
* Turn mw.usability.load() from a dummy function into a makeshift script loader that only loads JUI when requested and nothing else
* Move load() call in dialogs module up one level so it encompasses all jQuery UI function calls
* Move code using jQuery UI in TOC module out of the way, was being executed on page load. Will still cause JS errors if NTOC is enabled, will fix that later
Modified paths:
  • /trunk/extensions/UsabilityInitiative/Makefile (modified) (history)
  • /trunk/extensions/UsabilityInitiative/UsabilityInitiative.hooks.php (modified) (history)
  • /trunk/extensions/UsabilityInitiative/js/js2stopgap/jui.combined.js (added) (history)
  • /trunk/extensions/UsabilityInitiative/js/js2stopgap/jui.combined.min.js (added) (history)
  • /trunk/extensions/UsabilityInitiative/js/plugins.combined.js (modified) (history)
  • /trunk/extensions/UsabilityInitiative/js/plugins.combined.min.js (modified) (history)
  • /trunk/extensions/UsabilityInitiative/js/plugins/jquery.wikiEditor.dialogs.js (modified) (history)
  • /trunk/extensions/UsabilityInitiative/js/plugins/jquery.wikiEditor.js (modified) (history)
  • /trunk/extensions/UsabilityInitiative/js/plugins/jquery.wikiEditor.toc.js (modified) (history)
  • /trunk/extensions/UsabilityInitiative/js/usability.js (modified) (history)

Diff [purge]

The diff is too large to display.

Follow-up revisions

RevisionCommit summaryAuthorDate
r680271.16wmf4: Merge Vector and UsabilityInitiative fixes from trunk: r67836, r678...catrope20:25, 14 June 2010

Status & tagging log