r67953 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r67952‎ | r67953 | r67954 >
Date:14:41, 13 June 2010
Author:jeroendedauw
Status:deferred
Tags:
Comment:
Changes for 0.6.3 - Follow up to r67904
Modified paths:
  • /trunk/extensions/SemanticMaps/SemanticMaps.i18n.php (modified) (history)
  • /trunk/extensions/SemanticMaps/Services/GoogleMaps/SM_GoogleMapsFormInput.php (modified) (history)
  • /trunk/extensions/SemanticMaps/Services/GoogleMaps/SM_GoogleMapsQP.php (modified) (history)
  • /trunk/extensions/SemanticMaps/Services/YahooMaps/SM_YahooMapsFormInput.php (modified) (history)

Diff [purge]

Index: trunk/extensions/SemanticMaps/Services/YahooMaps/SM_YahooMapsFormInput.php
@@ -102,12 +102,11 @@
103103
104104 /**
105105 * @see SMFormInput::manageGeocoding()
106 - *
107106 */
108107 protected function manageGeocoding() {
109108 global $egYahooMapsKey;
110109 $this->enableGeocoding = strlen( trim( $egYahooMapsKey ) ) > 0;
111 - if ( $this->enableGeocoding ) MapsYahooMaps::addYMapDependencies( $this->output );
 110+ if ( $this->enableGeocoding ) $this->mService->addDependencies( $this->output );
112111 }
113112
114113 }
\ No newline at end of file
Index: trunk/extensions/SemanticMaps/Services/GoogleMaps/SM_GoogleMapsQP.php
@@ -103,7 +103,6 @@
104104 );
105105 EOT
106106 ) );
107 -
108107 }
109108
110109 /**
Index: trunk/extensions/SemanticMaps/Services/GoogleMaps/SM_GoogleMapsFormInput.php
@@ -115,7 +115,7 @@
116116 protected function manageGeocoding() {
117117 global $egGoogleMapsKey, $wgParser;
118118 $this->enableGeocoding = $egGoogleMapsKey != '';
119 - if ( $this->enableGeocoding ) MapsGoogleMaps::addGMapDependencies( $wgParser );
 119+ if ( $this->enableGeocoding ) $this->mService->addDependencies( $wgParser );
120120 }
121121
122122 }
\ No newline at end of file
Index: trunk/extensions/SemanticMaps/SemanticMaps.i18n.php
@@ -14,7 +14,6 @@
1515 /** English
1616 * @author Jeroen De Dauw
1717 */
18 -
1918 $messages['en'] = array(
2019 // General
2120 'semanticmaps_name' => 'Semantic Maps',

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r67904Changes for 0.6.3 - rewrote service handling (incompatible with SM for now)jeroendedauw16:15, 12 June 2010

Status & tagging log