r67945 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r67944‎ | r67945 | r67946 >
Date:13:55, 13 June 2010
Author:jeroendedauw
Status:deferred
Tags:
Comment:
Changes for 0.6.3 - Follow up to r67904
Modified paths:
  • /trunk/extensions/Maps/Includes/Maps_CoordinateParser.php (modified) (history)
  • /trunk/extensions/Maps/Maps.php (modified) (history)

Diff [purge]

Index: trunk/extensions/Maps/Includes/Maps_CoordinateParser.php
@@ -514,6 +514,7 @@
515515 */
516516 public static function parseAndFormat( $coordinates, $targetFormat = Maps_COORDS_FLOAT, $directional = false ) {
517517 $parsedCoords = self::parseCoordinates( $coordinates );
 518+
518519 if ( $parsedCoords ) {
519520 return self::formatCoordinates( $parsedCoords );
520521 } else {
Index: trunk/extensions/Maps/Maps.php
@@ -33,7 +33,7 @@
3434 echo '<b>Warning:</b> You need to have <a href="http://www.mediawiki.org/wiki/Extension:Validator">Validator</a> installed in order to use <a href="http://www.mediawiki.org/wiki/Extension:Maps">Maps</a>.';
3535 }
3636 else {
37 - define( 'Maps_VERSION', '0.6.3 a3' );
 37+ define( 'Maps_VERSION', '0.6.3 a4' );
3838
3939 // The different coordinate notations.
4040 define( 'Maps_COORDS_FLOAT', 'float' );
@@ -93,13 +93,13 @@
9494 wfLoadExtensionMessages( 'Maps' );
9595 }
9696
97 - wfRunHooks( 'MappingFeatureLoad' );
98 -
9997 // Load the service/ classes and interfaces.
10098 require_once $egMapsDir . 'Services/Maps_iMappingService.php';
10199 $wgAutoloadClasses['MapsMappingService'] = $egMapsDir . 'Services/Maps_MappingService.php';
102100
103 - wfRunHooks( 'MappingServiceLoad' );
 101+ wfRunHooks( 'MappingServiceLoad' );
 102+
 103+ wfRunHooks( 'MappingFeatureLoad' );
104104
105105 // Remove all hooked in services that should not be available.
106106 foreach ( $egMapsServices as $service => $data ) {

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r67904Changes for 0.6.3 - rewrote service handling (incompatible with SM for now)jeroendedauw16:15, 12 June 2010

Status & tagging log