r6793 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r6792‎ | r6793 | r6794 >
Date:11:42, 23 December 2004
Author:vibber
Status:old
Tags:
Comment:
* (bug 1164) Let wikitext be used in Loginprompt and Loginend messages
Modified paths:
  • /branches/REL1_4/phase3/RELEASE-NOTES (modified) (history)
  • /branches/REL1_4/phase3/includes/SkinTemplate.php (modified) (history)
  • /branches/REL1_4/phase3/includes/templates/Userlogin.php (modified) (history)

Diff [purge]

Index: branches/REL1_4/phase3/includes/SkinTemplate.php
@@ -964,8 +964,21 @@
965965 }
966966
967967 /**
 968+ * An ugly, ugly hack.
968969 * @access private
969970 */
 971+ function msgWiki( $str ) {
 972+ global $wgParser, $wgTitle, $wgOut, $wgUseTidy;
 973+
 974+ $text = $this->translator->translate( $str );
 975+ $parserOutput = $wgParser->parse( $text, $wgTitle,
 976+ $wgOut->mParserOptions, true );
 977+ echo $parserOutput->getText();
 978+ }
 979+
 980+ /**
 981+ * @access private
 982+ */
970983 function haveData( $str ) {
971984 return $this->data[$str];
972985 }
Index: branches/REL1_4/phase3/includes/templates/Userlogin.php
@@ -17,7 +17,7 @@
1818 <p class='error'><?php $this->html('error') ?></p>
1919 <?php } else { ?>
2020 <h2><?php $this->msg('login' ) ?>:</h2>
21 - <p><?php $this->msg('loginprompt') ?></p>
 21+ <p><?php $this->msgWiki('loginprompt') ?></p>
2222 <?php } ?>
2323 <form name="userlogin" id="userlogin" method="post" action="<?php $this->text('action') ?>">
2424 <table border='0'>
@@ -102,7 +102,7 @@
103103 </table>
104104 </form>
105105 <?php
106 - $this->msgHtml( 'loginend' );
 106+ $this->msgWiki( 'loginend' );
107107 }
108108 }
109109
Index: branches/REL1_4/phase3/RELEASE-NOTES
@@ -157,8 +157,8 @@
158158 * Undo overly bright, difficult to read colors in Cologne Blue
159159 * (bug 1162) fix five-tilde date inserter
160160 * Add raw signatures option for those who simply must have cute sigs
 161+* (bug 1164) Let wikitext be used in Loginprompt and Loginend messages
161162
162 -
163163 === Caveats ===
164164
165165 Some output, particularly involving user-supplied inline HTML, may not

Follow-up revisions

RevisionCommit summaryAuthorDate
r6794* (bug 1164) Let wikitext be used in Loginprompt and Loginend messagesvibber11:43, 23 December 2004

Status & tagging log