r67907 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r67906‎ | r67907 | r67908 >
Date:17:08, 12 June 2010
Author:raymond
Status:ok
Tags:
Comment:
Use proper tooltipAndAccessKeyAttribs()
Use Html::() instead of Xml::()
Modified paths:
  • /trunk/phase3/includes/HistoryPage.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/HistoryPage.php
@@ -375,23 +375,20 @@
376376 $this->oldIdChecked = 0;
377377
378378 $wgOut->wrapWikiMsg( "<div class='mw-history-legend'>\n$1\n</div>", 'histlegend' );
379 - $s = Xml::openElement( 'form', array( 'action' => $wgScript,
 379+ $s = Html::openElement( 'form', array( 'action' => $wgScript,
380380 'id' => 'mw-history-compare' ) ) . "\n";
381 - $s .= Xml::hidden( 'title', $this->title->getPrefixedDbKey() ) . "\n";
382 - $s .= Xml::hidden( 'action', 'historysubmit' ) . "\n";
 381+ $s .= Html::hidden( 'title', $this->title->getPrefixedDbKey() ) . "\n";
 382+ $s .= Html::hidden( 'action', 'historysubmit' ) . "\n";
383383
384384 $this->buttons = '<div>';
385385 $this->buttons .= $this->submitButton( wfMsg( 'compareselectedversions'),
386 - array(
387 - 'class' => 'historysubmit',
388 - 'accesskey' => wfMsg( 'accesskey-compareselectedversions' ),
389 - 'title' => wfMsg( 'tooltip-compareselectedversions' ),
390 - )
 386+ array( 'class' => 'historysubmit' )
 387+ + $wgUser->getSkin()->tooltipAndAccessKeyAttribs( 'compareselectedversions' )
391388 ) . "\n";
392389 if( $wgUser->isAllowed('deleterevision') ) {
393390 $float = $wgContLang->alignEnd();
394391 # Note bug #20966, <button> is non-standard in IE<8
395 - $this->buttons .= Xml::element( 'button',
 392+ $this->buttons .= Html::element( 'button',
396393 array(
397394 'type' => 'submit',
398395 'name' => 'revisiondelete',
@@ -405,7 +402,7 @@
406403 if( $wgUser->isAllowed( 'revisionmove' ) ) {
407404 $float = $wgContLang->alignEnd();
408405 # Note bug #20966, <button> is non-standard in IE<8
409 - $this->buttons .= Xml::element( 'button',
 406+ $this->buttons .= Html::element( 'button',
410407 array(
411408 'type' => 'submit',
412409 'name' => 'revisionmove',

Status & tagging log