r67905 MediaWiki - Code Review archive

Repository:	MediaWiki
Revision:	< r67904‎ \| r67905 \| r67906 >
Date:	16:31, 12 June 2010
Author:	jeroendedauw
Status:	deferred
Tags:
Comment:	Follow up to r67904 - documentation update
Modified paths:	/trunk/extensions/Maps/Services/GoogleMaps/GoogleMaps.php (modified) (history) /trunk/extensions/Maps/Services/GoogleMaps/Maps_GoogleMaps.php (modified) (history) /trunk/extensions/Maps/Services/GoogleMaps3/GoogleMaps3.php (modified) (history) /trunk/extensions/Maps/Services/GoogleMaps3/Maps_GoogleMaps3.php (modified) (history) /trunk/extensions/Maps/Services/OpenLayers/Maps_OpenLayers.php (modified) (history) /trunk/extensions/Maps/Services/OpenLayers/OpenLayers.php (modified) (history) /trunk/extensions/Maps/Services/YahooMaps/Maps_YahooMaps.php (modified) (history) /trunk/extensions/Maps/Services/YahooMaps/YahooMaps.php (modified) (history)

Diff [purge]

Index: trunk/extensions/Maps/Services/GoogleMaps3/GoogleMaps3.php
—	—	@@ -1,5 +1,25 @@
2	2	<?php
3	3
	4	+/**
	5	+ * This groupe contains all Google Maps v3 related files of the Maps extension.
	6	+ *
	7	+ * @defgroup MapsGoogleMaps3 Google Maps v3
	8	+ * @ingroup Maps
	9	+ */
	10	+
	11	+/**
	12	+ * This file holds the hook and initialization for the Google Maps v3 service.
	13	+ *
	14	+ * @file GoogleMaps3.php
	15	+ * @ingroup MapsGoogleMaps3
	16	+ *
	17	+ * @author Jeroen De Dauw
	18	+ */
	19	+
	20	+if ( !defined( 'MEDIAWIKI' ) ) {
	21	+ die( 'Not an entry point.' );
	22	+}
	23	+
4	24	$wgHooks['MappingServiceLoad'][] = 'efMapsInitGoogleMaps3';
5	25
6	26	function efMapsInitGoogleMaps3() {
Index: trunk/extensions/Maps/Services/GoogleMaps3/Maps_GoogleMaps3.php
—	—	@@ -1,14 +1,7 @@
2	2	<?php
3	3
4	4	/**
5		~~- * This groupe contains all Google Maps v3 related files of the Maps extension.~~
6		- *
7		~~- * @defgroup MapsGoogleMaps3 Google Maps v3~~
8		~~- * @ingroup Maps~~
9		~~- */~~
10		-
11		-/**
12		~~- * This file holds the general information for the Google Maps v3 service.~~
	5	+ * File holding the MapsGoogleMaps3 class.
13	6	*
14	7	* @file Maps_GoogleMaps3.php
15	8	* @ingroup MapsGoogleMaps3
—	—	@@ -21,7 +14,7 @@
22	15	}
23	16
24	17	/**
25		~~- * Class for Google Maps v3 initialization.~~
	18	+ * TODO
26	19	*
27	20	* @ingroup MapsGoogleMaps3
28	21	*
Index: trunk/extensions/Maps/Services/YahooMaps/Maps_YahooMaps.php
—	—	@@ -1,14 +1,7 @@
2	2	<?php
3	3
4	4	/**
5		~~- * This groupe contains all Yahoo! Maps related files of the Maps extension.~~
6		- *
7		~~- * @defgroup MapsYahooMaps Yahoo! Maps~~
8		~~- * @ingroup Maps~~
9		~~- */~~
10		-
11		-/**
12		~~- * This file holds the general information for the Yahoo! Maps service~~
	5	+ * File holding the MapsYahooMaps class.
13	6	*
14	7	* @file Maps_YahooMaps.php
15	8	* @ingroup MapsYahooMaps
—	—	@@ -21,7 +14,7 @@
22	15	}
23	16
24	17	/**
25		~~- * Class for Yahoo! Maps initialization.~~
	18	+ * TODO
26	19	*
27	20	* @ingroup MapsYahooMaps
28	21	*
Index: trunk/extensions/Maps/Services/YahooMaps/YahooMaps.php
—	—	@@ -1,5 +1,25 @@
2	2	<?php
3	3
	4	+/**
	5	+ * This groupe contains all Yahoo! Maps related files of the Maps extension.
	6	+ *
	7	+ * @defgroup MapsYahooMaps Yahoo! Maps
	8	+ * @ingroup Maps
	9	+ */
	10	+
	11	+/**
	12	+ * This file holds the hook and initialization for the Yahoo! Maps service.
	13	+ *
	14	+ * @file YahooMaps.php
	15	+ * @ingroup MapsYahooMaps
	16	+ *
	17	+ * @author Jeroen De Dauw
	18	+ */
	19	+
	20	+if ( !defined( 'MEDIAWIKI' ) ) {
	21	+ die( 'Not an entry point.' );
	22	+}
	23	+
4	24	$wgHooks['MappingServiceLoad'][] = 'efMapsInitYahooMaps';
5	25
6	26	function efMapsInitYahooMaps() {
Index: trunk/extensions/Maps/Services/OpenLayers/Maps_OpenLayers.php
—	—	@@ -1,14 +1,7 @@
2	2	<?php
3	3
4	4	/**
5		~~- * This groupe contains all OpenLayers related files of the Maps extension.~~
6		- *
7		~~- * @defgroup MapsOpenLayers OpenLayers~~
8		~~- * @ingroup Maps~~
9		~~- */~~
10		-
11		-/**
12		~~- * This file holds the general information for the OpenLayers service~~
	5	+ * File holding the MapsOpenLayers class.
13	6	*
14	7	* @file Maps_OpenLayers.php
15	8	* @ingroup MapsOpenLayers
—	—	@@ -21,7 +14,7 @@
22	15	}
23	16
24	17	/**
25		~~- * Class for OpenLayers initialization.~~
	18	+ * TODO
26	19	*
27	20	* @ingroup MapsOpenLayers
28	21	*
Index: trunk/extensions/Maps/Services/OpenLayers/OpenLayers.php
—	—	@@ -1,5 +1,25 @@
2	2	<?php
3	3
	4	+/**
	5	+ * This groupe contains all OpenLayers related files of the Maps extension.
	6	+ *
	7	+ * @defgroup MapsOpenLayers OpenLayers
	8	+ * @ingroup Maps
	9	+ */
	10	+
	11	+/**
	12	+ * This file holds the hook and initialization for the OpenLayers service.
	13	+ *
	14	+ * @file OpenLayers.php
	15	+ * @ingroup MapsOpenLayers
	16	+ *
	17	+ * @author Jeroen De Dauw
	18	+ */
	19	+
	20	+if ( !defined( 'MEDIAWIKI' ) ) {
	21	+ die( 'Not an entry point.' );
	22	+}
	23	+
4	24	$wgHooks['MappingServiceLoad'][] = 'efMapsInitOpenLayers';
5	25
6	26	function efMapsInitOpenLayers() {
Index: trunk/extensions/Maps/Services/GoogleMaps/GoogleMaps.php
—	—	@@ -1,5 +1,25 @@
2	2	<?php
3	3
	4	+/**
	5	+ * This groupe contains all Google Maps v2 related files of the Maps extension.
	6	+ *
	7	+ * @defgroup MapsGoogleMaps Google Maps v2
	8	+ * @ingroup Maps
	9	+ */
	10	+
	11	+/**
	12	+ * This file holds the hook and initialization for the Google Maps v2 service.
	13	+ *
	14	+ * @file GoogleMaps.php
	15	+ * @ingroup MapsGoogleMaps
	16	+ *
	17	+ * @author Jeroen De Dauw
	18	+ */
	19	+
	20	+if ( !defined( 'MEDIAWIKI' ) ) {
	21	+ die( 'Not an entry point.' );
	22	+}
	23	+
4	24	$wgHooks['MappingServiceLoad'][] = 'efMapsInitGoogleMaps';
5	25
6	26	function efMapsInitGoogleMaps() {
Index: trunk/extensions/Maps/Services/GoogleMaps/Maps_GoogleMaps.php
—	—	@@ -1,14 +1,7 @@
2	2	<?php
3	3
4	4	/**
5		~~- * This groupe contains all Google Maps related files of the Maps extension.~~
6		- *
7		~~- * @defgroup MapsGoogleMaps Google Maps~~
8		~~- * @ingroup Maps~~
9		~~- */~~
10		-
11		-/**
12		~~- * This file holds the general information for the Google Maps service~~
	5	+ * File holding the MapsGoogleMaps class.
13	6	*
14	7	* @file Maps_GoogleMaps.php
15	8	* @ingroup MapsGoogleMaps
—	—	@@ -21,7 +14,7 @@
22	15	}
23	16
24	17	/**
25		~~- * Class for Google Maps initialization.~~
	18	+ * TODO
26	19	*
27	20	* @ingroup MapsGoogleMaps
28	21	*

Past revisions this follows-up on

Revision	Commit summary	Author	Date
r67904	Changes for 0.6.3 - rewrote service handling (incompatible with SM for now)	jeroendedauw	16:15, 12 June 2010

Status & tagging log

19:50, 12 June 2010 Reedy (talk | contribs) changed the status of r67905 [removed: new added: deferred]